Page MenuHomePhabricator

Unify and polish error handling experience between filepage and Upload Wizard
Closed, ResolvedPublic


User story: As a Commons user, when I enter or submit structured data for a file, I want informative help text and error messages to aid me in the process both on the filepage and in Upload Wizard.

We have this: wbparsevalue errors are displayed via MessageWidget above the offending input on add, which is exactly what we want and matches behavior of the filepage UI.

However, checks that run on submission of all data might be hidden if the user isn't viewing the offending file when they click the publish button. So, if I add invalid data for the first image in the booklet, then click to the second and add more data, then submit, I won't see any indication that the error that occurred is on the first booklet page.

We want this: When a user clicks "publish data" but an error occurs, they should see a visual indication of which booklet page has the error. They should also see a generic error above the publish button informing them that errors exist.

To test: use Upload Wizard to add at least 2 images, then progress to the metadata step. For the first image, add a depicts statement, then add a URL qualifier (e.g. official website) with no scheme (e.g. Go to the second booklet page to view the second image. Click publish data. You should see a generic error message above the publish button and the first booklet tab should be highlighted. Click on the first booklet tab - you should see the specific error message for the URL field.

Acceptance Criteria:

  • Users can easily tell when an error occurs, which file(s) are affected, which field(s) caused it, and how to fix it.

During development, please test the following:

  • Test this feature on at least one mobile browser
  • Test that this feature works on the file page AND the Add Data step on UploadWizard (if applicable, some features only exist on one or the other)

Event Timeline

AnneT removed AnneT as the assignee of this task.Sep 16 2019, 8:59 PM
AnneT created this task.
AnneT updated the task description. (Show Details)

Change 566889 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/UploadWizard@master] Highlight metadata publish errors

Change 566889 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Highlight metadata publish errors

Tested on production UploadWizard and appears to work. Nice job! 👍🏼