Page MenuHomePhabricator
Create Task
Maniphest T233083

Add dist files to ResourceLoader
Closed, ResolvedPublic
Actions

Description

Ensure webpack builds files with sensible names:

  • use: tainted-ref
  • look in vue.config.js for where this is set
  • load these files in a sensible place in resourceloader so they appear on every statement containing entity page
  • see if you can avoid adding yet another resourceloader module (to not annoy the terminator team).

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Launch tainted-ref on entityLoaded mw.hookmediawiki/extensions/Wikibasemaster+8 -2
Load tainted-ref using ResourceLoadermediawiki/extensions/Wikibasemaster+161 -74
Load the wikibase.tainted-ref RL module, check settingmediawiki/extensions/Wikibasemaster+132 -98
Add "wikibase.tainted-ref" RL modulemediawiki/extensions/Wikibasemaster+206 -7
Customize query in gerrit

Related Objects

Event Timeline

Tarrow created this task.Sep 17 2019, 8:24 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 17 2019, 8:24 AM
hoo claimed this task.Sep 17 2019, 10:29 AM
hoo moved this task from To Do to Doing on the Wikidata-Tainted-References-Sprint1 board.
gerritbot added a comment.Sep 17 2019, 3:06 PM

Change 537459 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Add "wikibase.tainted-ref" RL module

https://gerrit.wikimedia.org/r/537459

gerritbot added a project: Patch-For-Review.Sep 17 2019, 3:06 PM
hoo mentioned this in T233107: Make vue linting and testing run with CI.Sep 17 2019, 6:12 PM
gerritbot added a comment.Sep 18 2019, 3:42 PM

Change 537459 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add "wikibase.tainted-ref" RL module

https://gerrit.wikimedia.org/r/537459

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.24; 2019-09-24).Sep 18 2019, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 18 2019, 4:10 PM
gerritbot added a comment.Sep 18 2019, 8:03 PM

Change 537746 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Load the wikibase.tainted-ref RL module, check setting

https://gerrit.wikimedia.org/r/537746

gerritbot added a project: Patch-For-Review.Sep 18 2019, 8:03 PM
hoo moved this task from Doing to Peer Review on the Wikidata-Tainted-References-Sprint1 board.Sep 18 2019, 8:04 PM
WMDE-leszek added a project: Wikidata-Tainted-References-Sprint2.Sep 23 2019, 11:02 AM
WMDE-leszek moved this task from To Do to Peer Review on the Wikidata-Tainted-References-Sprint2 board.
gerritbot added a comment.Oct 1 2019, 10:10 AM

Change 540092 had a related patch set uploaded (by Tarrow; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Load tainted-ref using ResourceLoader

https://gerrit.wikimedia.org/r/540092

gerritbot added a comment.Oct 1 2019, 10:22 AM

Change 537746 abandoned by Tarrow:
Load the wikibase.tainted-ref RL module, check setting

Reason:
abandoned in favour of I9a244a36fe940a96578ebf997efc885ff3384d30

https://gerrit.wikimedia.org/r/537746

WMDE-leszek added a project: Wikidata-Tainted-References-Sprint3.Oct 7 2019, 12:05 PM
WMDE-leszek moved this task from To Do to Peer Review on the Wikidata-Tainted-References-Sprint3 board.
gerritbot added a comment.Oct 7 2019, 3:12 PM

Change 540092 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Load tainted-ref using ResourceLoader

https://gerrit.wikimedia.org/r/540092

• noarave moved this task from Peer Review to Done on the Wikidata-Tainted-References-Sprint3 board.Oct 8 2019, 6:42 AM
Maintenance_bot removed a project: Patch-For-Review.Oct 8 2019, 7:10 AM
gerritbot added a comment.Oct 11 2019, 1:29 PM

Change 542430 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Launch tainted-ref on entityLoaded mw.hook

https://gerrit.wikimedia.org/r/542430

gerritbot added a project: Patch-For-Review.Oct 11 2019, 1:29 PM
gerritbot added a comment.Oct 11 2019, 1:57 PM

Change 542430 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Launch tainted-ref on entityLoaded mw.hook

https://gerrit.wikimedia.org/r/542430

Maintenance_bot removed a project: Patch-For-Review.Oct 11 2019, 2:10 PM
Tarrow closed this task as Resolved.Oct 22 2019, 2:22 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits