Page MenuHomePhabricator

Add dist files to ResourceLoader
Closed, ResolvedPublic

Description

Ensure webpack builds files with sensible names:

  • use: tainted-ref
  • look in vue.config.js for where this is set
  • load these files in a sensible place in resourceloader so they appear on every statement containing entity page
  • see if you can avoid adding yet another resourceloader module (to not annoy the terminator team).

Details

Related Gerrit Patches:
mediawiki/extensions/Wikibase : masterLaunch tainted-ref on entityLoaded mw.hook
mediawiki/extensions/Wikibase : masterLoad tainted-ref using ResourceLoader
mediawiki/extensions/Wikibase : masterLoad the wikibase.tainted-ref RL module, check setting
mediawiki/extensions/Wikibase : masterAdd "wikibase.tainted-ref" RL module

Event Timeline

Tarrow created this task.Sep 17 2019, 8:24 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 17 2019, 8:24 AM
hoo claimed this task.Sep 17 2019, 10:29 AM
hoo moved this task from To Do to Doing on the Wikidata-Tainted-References-Sprint1 board.

Change 537459 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Add "wikibase.tainted-ref" RL module

https://gerrit.wikimedia.org/r/537459

Change 537459 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add "wikibase.tainted-ref" RL module

https://gerrit.wikimedia.org/r/537459

Change 537746 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Load the wikibase.tainted-ref RL module, check setting

https://gerrit.wikimedia.org/r/537746

Change 540092 had a related patch set uploaded (by Tarrow; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Load tainted-ref using ResourceLoader

https://gerrit.wikimedia.org/r/540092

Change 537746 abandoned by Tarrow:
Load the wikibase.tainted-ref RL module, check setting

Reason:
abandoned in favour of I9a244a36fe940a96578ebf997efc885ff3384d30

https://gerrit.wikimedia.org/r/537746

Change 540092 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Load tainted-ref using ResourceLoader

https://gerrit.wikimedia.org/r/540092

Change 542430 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Launch tainted-ref on entityLoaded mw.hook

https://gerrit.wikimedia.org/r/542430

Change 542430 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Launch tainted-ref on entityLoaded mw.hook

https://gerrit.wikimedia.org/r/542430

Tarrow closed this task as Resolved.Tue, Oct 22, 2:22 PM