Wikilinking a label with a HTML entities in it freezes the Visual Editor
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Waddie96
	Sep 17 2019, 11:46 AM

Description

Wikilinking a label with the ′ symbol in it, represented either by ′ or ′, will freeze the Wikilinking function in the Visual Editor.

To recreate:

Go to en:GC skew and edit with Visual Editor
Wikilink the text 5′ to Directionality (molecular biology)
The Wikilinking feature will freeze and the page will have to be reloaded and changes restored for you to continue editing (screenshot of the 'freeze' below)

Browser: Version 76.0.3809.132 (Official Build) (64-bit)
Note: I reproduced this on https://test2.wikipedia.org too

Screenshot 2019-09-17 at 13.33.07.png (900×1 px, 413 KB)

Related Objects

Mentioned In: T215567: Split TreeModifier into a tree diff generator and tree diff applier
Mentioned Here: T234742: TreeModifier: ensureNotText can return the wrong position
T234881: TreeModifier: remover does not skip over a deleted node immediately following a text node
rEVEDece13d7e16c2: Update VE core submodule to master (81e2e57a5)

Event Timeline

Waddie96 created this task.Sep 17 2019, 11:46 AM

Waddie96 moved this task from Incoming to Bugs on the Wikilink-Tool board.Sep 17 2019, 11:54 AM

Waddie96 updated the task description. (Show Details)Sep 17 2019, 11:58 AM

Waddie96 updated the task description. (Show Details)

Samwalton9-WMF removed a project: Wikilink-Tool.Sep 26 2019, 2:02 PM

We will take a look at this

JTannerWMF moved this task from Incoming to Investigating on the VisualEditor (Current work) board.Oct 10 2019, 4:21 PM

I remember I could reproduce this when I tried it soon after you filed this task (and determining that it was caused by using HTML entities in general, rather than the prime symbol – I forgot to leave a comment…), but now the issue no longer occurs.

Never mind, I can reproduce it again. The issue occurs only if the entity is in the middle of the selected text (it works fine now if it's at the beginning or end), for example try selecting and linking 5′- somewhere on that page.

The issue was introduced in rEVEDece13d7e16c2: Update VE core submodule to master (81e2e57a5) (the TreeModifier commit).

The exception is:

Error: Cannot insert text into a mwEntity node
    at VeDmTreeModifier.ve.dm.TreeModifier.checkCanInsertText
    at VeDmTreeModifier.ve.dm.TreeModifier.pushInsertTextOp
    at VeDmTreeModifier.ve.dm.TreeModifier.processInsert
    at VeDmTreeModifier.ve.dm.TreeModifier.processLinearOperation
    at VeDmTreeModifier.ve.dm.TreeModifier.calculateTreeOperations
    at VeDmTreeModifier.ve.dm.TreeModifier.process
    at VeDmTransactionProcessor.ve.dm.TransactionProcessor.process
    at VeDmDocument.ve.dm.Document.commit
    at VeDmSurface.ve.dm.Surface.changeInternal
    at VeDmSurface.ve.dm.Surface.change

matmarex mentioned this in T215567: Split TreeModifier into a tree diff generator and tree diff applier.Oct 10 2019, 11:56 PM

matmarex renamed this task from Wikilinking a label with a 'prime' symbol in it freezes the Visual Editor to Wikilinking a label with a HTML entities in it freezes the Visual Editor.Oct 11 2019, 12:07 AM

I can no longer reproduce this on https://en.wikipedia.org/w/index.php?title=GC_skew&oldid=917245666 – Adding a link annotation to "locations plotted 5′ to 3′ and y-axis" appears to work fine.

Reproducing on old code, I think it was a combination of T234881 and T234742 .

Waddie96 awarded a token.Oct 12 2019, 2:03 PM