Page MenuHomePhabricator

Make vue linting and testing run with CI
Closed, ResolvedPublic

Description

We should not be able to merge code that is poorly formatted.

Running the tests might be blocked by having the build work in which case this task should also fix that.

Event Timeline

Tarrow created this task.Sep 17 2019, 12:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 17 2019, 12:52 PM
Tarrow claimed this task.Sep 17 2019, 12:52 PM
hoo added a subscriber: hoo.Sep 17 2019, 6:12 PM

I'm also working on the build for T233083, so we might want to make this a follow up of that (or vice versa).

Current sequential install time with npm install takes:
npm install 144.30s user 63.94s system 75% cpu 4:35.22 total

Current sequential install time with npm ci takes:
npm ci --verbose 88.89s user 51.78s system 125% cpu 1:52.24 total

Parallel: npm ci:
npm ci --verbose 78.94s user 42.81s system 212% cpu 57.290 total

Current sequential test run npm test takes (with one lint failure):
npm test 328.05s user 42.52s system 133% cpu 4:37.35 total

Parallel test run:
npm test 310.66s user 43.13s system 141% cpu 4:09.43 total

Looks like running in parallel would certainly be worth while.

Change 537986 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] Tainted-ref: Make linting tests run on CI

https://gerrit.wikimedia.org/r/537986

Change 537987 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] Use npm-run-all for install and test of node subcomponents

https://gerrit.wikimedia.org/r/537987

Change 537986 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Tainted-ref: Make linting tests run on CI

https://gerrit.wikimedia.org/r/537986

WMDE-leszek closed this task as Resolved.Sep 23 2019, 11:16 AM
DannyS712 added a subscriber: DannyS712.

[batch] remove patch for review tag from resolved tasks

Change 537987 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use npm-run-all for install and test of node subcomponents

https://gerrit.wikimedia.org/r/537987