Page MenuHomePhabricator

Available on sister projects template has layout problems
Closed, ResolvedPublicBUG REPORT

Description

Device: Wkipedia 6.4 1674, iOS 12.4.1, iPhone X

Steps to Reproduce:

  1. Go to any article with the sister projects box (Obama on en.wp for example)

Actual Results:

See screenshot:

IMG_5036.PNG (2×1 px, 312 KB)
Text is unreadable, sister project icons are low res and have backgrounds included (white), title text is constrained to part of the width and wraps oddly, etc...

Expected Results:
Either

  • hide this template (it navigates to projects not supported in app)

or

  • fix the css to be reasonable on phones and compatible with theming colors.

Event Timeline

If we can fix the layout issues or get the template updated great, but if not, or it will complex, lets hide these for now.

Looks to be a template issue... all funky on mobile web too:

Screen Shot 2019-09-19 at 5.16.24 PM.png (1×706 px, 409 KB)

Looking into it...

Funky times on desktop too...

Screen Shot 2019-09-19 at 5.31.45 PM.png (1×612 px, 426 KB)

As seen in the desktop screenshot above, the template, and the navbox templates above and below it, haven't been optimized for narrow screen layouts.

I was going to tweak it, but given how it lays out on desktop when the screen is wide, I think it may be a bit of a rabbit hole and may be better to just hide it as we do the surrounding nav boxes.

On the Obama article the wiki text appears to be...

{{Subject bar
| commons = y
| n = y
| n-search = Category:Barack Obama
| d = y
| d-search = Q76
| q = y
| s = y
| s-search = Author:Barack Obama
}}

Looks like the html it outputs doesn't have anything which would let us identify and hide this Subject bar template output specifically 🤔

Though I suppose every Subject bar would have similarly messed up layout... will poke around to see how common they are...

Put in blocked pending hearing back about @JMinor's raising this with mobile web team. See these comments above:
https://phabricator.wikimedia.org/T233128#5508254
https://phabricator.wikimedia.org/T233128#5508288

Jdlrobson subscribed.

This is an issue with the template - I can replicate it on Minerva desktop: https://en.wikipedia.org/wiki/Barack%20Obama?useskin=minerva

Screenshot 2019-10-08 at 12.07.30 PM.png (609×343 px, 78 KB)

The template with the problem appears to be https://en.wikipedia.org/wiki/Template:Subject_bar

https://www.mediawiki.org/wiki/Reading/Web/Working_with_editors_to_get_templates_fixed has some notes on the process parts of how to fix this problem (but this is explicitly not a responsibility of the reading web team).

Mhurd removed Mhurd as the assignee of this task.Jul 23 2020, 8:45 PM
Mhurd subscribed.
MSantos added subscribers: MattCleinman, LGoto, MSantos.

@Jdlrobson nice to know about this procedure to get templates fixed by the community! It's not odd to have templates that work on the web but don't in Page Content Service.

I wonder if we can make an effort to improve it with a workflow and/or RACI matrix between the stakeholders, e. g. Product Infrastructure, Apps, and Web, to get these fixes requests to reach the editor community.

cc/ @LGoto and @MattCleinman

A formal procedure here would be nice as it's something we commonly run into, but to work would likely need community ambassadors, cc @sgrabarczuk

Pending someone reverting me, I've made TheDJ's version live, so this should be resolved Soon?

Izno assigned this task to TheDJ.