Page MenuHomePhabricator

DefaultPreferencesFactoryTest:testIntvalFilter takes ~8s for a pretty trivial test for a single preference value
Closed, ResolvedPublic

Event Timeline

It seems this has changed

MacBook:tests Ammar$ php phpunit/phpunit.php --filter testIntvalFilter phpunit/includes/preferences/DefaultPreferencesFactoryTest.php
Using PHP 7.3.8
PHPUnit 8.5.14 by Sebastian Bergmann and contributors.

.                                                                   1 / 1 (100%)

Time: 3.1 seconds, Memory: 58.50 MB

OK (1 test, 2 assertions)

With PHP 8, it even takes less time (and less memory) consistently. Average is 2 seconds over 1000 runs.

MacBook:phpunit Ammar$ unit --filter testIntvalFilter includes/preferences/DefaultPreferencesFactoryTest.php
Using PHP 8.0.3
PHPUnit 8.5.14 by Sebastian Bergmann and contributors.

.                                                                   1 / 1 (100%)

Time: 1.95 seconds, Memory: 50.50 MB

OK (1 test, 2 assertions)

I don't know whether this is 'fast enough' but looks pretty significant improvement over what is reported here.