Page MenuHomePhabricator

Quibble should not rely on dynamically detecting the value of $wgServer
Closed, ResolvedPublic


To unblock T232931: Remove support for run-time automatic $wgServer default value, quibble needs to explicitly supply the value for $wgServer to the installer, using the new --server option. From the patch

Looks like the quibble jobs are still depending on this. Their generated settings are now getting "$wgServer = "http://localhost";" which is wrong (should be something like "", which I guess it needs to pass it from its ENV var).


Related Gerrit Patches:
integration/config : masterdocker: bump quibble to 0.0.38
integration/quibble : masterSet $wgServer when installing

Event Timeline

hashar added a subscriber: hashar.Sep 23 2019, 9:20 AM

From the CLI maintenance/shell.php the port is obviously not detected:

>>> $wgServer;
=> "http://localhost"

Via the webserver: http://localhost:9412 (correct).

maintenance/install.php supports passing the server via --server and that seems to work. At least in the master branch.

Change 538583 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/quibble@master] Set $wgServer when installing

Change 538583 merged by jenkins-bot:
[integration/quibble@master] Set $wgServer when installing

hashar claimed this task.Sep 23 2019, 9:51 AM
hashar edited projects, added Quibble; removed Patch-For-Review.
hashar moved this task from Backlog to In progress on the Quibble board.
hashar moved this task from In progress to Pending release on the Quibble board.Sep 23 2019, 9:56 AM
hashar added a comment.Oct 9 2019, 9:53 AM

Setting $wgServer leads to a Selenium test to fail :-\ T235023

Change 541811 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] docker: bump quibble to 0.0.38

Change 541811 merged by jenkins-bot:
[integration/config@master] docker: bump quibble to 0.0.38

hashar closed this task as Resolved.Oct 9 2019, 1:06 PM

Further fixed up in 0.0.38 due to T235023