Page MenuHomePhabricator
Create Task
Maniphest T233140

Quibble should not rely on dynamically detecting the value of $wgServer
Closed, ResolvedPublic
Actions

Description

To unblock T232931: Remove support for run-time automatic $wgServer default value, quibble needs to explicitly supply the value for $wgServer to the installer, using the new --server option. From the patch https://gerrit.wikimedia.org/r/c/mediawiki/core/+/524396:

Looks like the quibble jobs are still depending on this. Their generated settings are now getting "$wgServer = "http://localhost";" which is wrong (should be something like "http://127.0.0.1:9412", which I guess it needs to pass it from its ENV var).

Details

SubjectRepoBranchLines +/-
docker: bump quibble to 0.0.38integration/configmaster+48 -0
Set $wgServer when installingintegration/quibblemaster+4 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

daniel created this task.Sep 17 2019, 6:28 PM
daniel removed a project: Technical-Debt (Deprecation process).
Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.Sep 20 2019, 10:40 PM
Krinkle removed a parent task: T232931: Remove support for run-time automatic $wgServer default value.
Krinkle added a parent task: T232931: Remove support for run-time automatic $wgServer default value.
Krinkle removed a project: Performance-Team (Radar).
hashar subscribed.Sep 23 2019, 9:20 AM

From the CLI maintenance/shell.php the port is obviously not detected:

>>> $wgServer;
=> "http://localhost"

Via the webserver: http://localhost:9412 (correct).

maintenance/install.php supports passing the server via --server and that seems to work. At least in the master branch.

gerritbot added a comment.Sep 23 2019, 9:37 AM

Change 538583 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/quibble@master] Set $wgServer when installing

https://gerrit.wikimedia.org/r/538583

gerritbot added a project: Patch-For-Review.Sep 23 2019, 9:37 AM
gerritbot added a comment.Sep 23 2019, 9:39 AM

Change 538583 merged by jenkins-bot:
[integration/quibble@master] Set $wgServer when installing

https://gerrit.wikimedia.org/r/538583

hashar claimed this task.Sep 23 2019, 9:51 AM
hashar edited projects, added Quibble; removed Patch-For-Review.
hashar moved this task from Backlog to In progress on the Quibble board.
hashar moved this task from In progress to Pending release on the Quibble board.Sep 23 2019, 9:56 AM
hashar moved this task from Untriaged to In-progress on the Continuous-Integration-Infrastructure board.Sep 27 2019, 1:13 PM
Stashbot mentioned this in T181942: Run composer --version in CI jobs.Oct 8 2019, 8:19 PM
Stashbot mentioned this in T190829: Test WikiTextEditor class with browser tests..
Stashbot mentioned this in T199939: Audit tests/selenium/LocalSettings.php file aiming at possibly deprecating the feature.
Stashbot mentioned this in T230340: Set up CI for mediawiki/tools/api-testing.

Mentioned in SAL (#wikimedia-releng) [2019-10-08T20:19:18Z] <hashar> Tag Quibble 0.0.36 @ 4b46156 # T181942 T190829 T199939 T230340 T233140 T233143

Stashbot mentioned this in T233143: Quibble should fatal out on clone/fetch failure"ERROR:zuul.Repo:Unable to initialize repo for npm-test.git".Oct 8 2019, 8:19 PM
hashar mentioned this in T235023: Selenium test "User should be able to log in @daily" fails with Quibble 0.0.37.Oct 9 2019, 9:23 AM
hashar added a comment.Oct 9 2019, 9:53 AM

Setting $wgServer leads to a Selenium test to fail :-\ T235023

hashar added a subtask: T235023: Selenium test "User should be able to log in @daily" fails with Quibble 0.0.37.Oct 9 2019, 9:53 AM
gerritbot added a comment.Oct 9 2019, 1:01 PM

Change 541811 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] docker: bump quibble to 0.0.38

https://gerrit.wikimedia.org/r/541811

gerritbot added a project: Patch-For-Review.Oct 9 2019, 1:01 PM
hashar closed subtask T235023: Selenium test "User should be able to log in @daily" fails with Quibble 0.0.37 as Resolved.Oct 9 2019, 1:02 PM
gerritbot added a comment.Oct 9 2019, 1:03 PM

Change 541811 merged by jenkins-bot:
[integration/config@master] docker: bump quibble to 0.0.38

https://gerrit.wikimedia.org/r/541811

hashar closed this task as Resolved.Oct 9 2019, 1:06 PM

Further fixed up in 0.0.38 due to T235023

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL