| Mooeypoo | |
| Sep 17 2019, 9:35 PM |
| F30849525: less_than_1.png | |
| Oct 18 2019, 10:32 AM |
| F30382562: wwt-missing-percentage.png | |
| Sep 17 2019, 9:35 PM |
As a WWT user, I should see an integer for percentage of page contributed by user, so that I understand the total contribution of the user.
Acceptance Criteria:
Visual Examples:
Found on this article: https://en.wikipedia.org/wiki/Charles_Hamya
@ifried this bug was introduced in patch https://github.com/wikimedia/WhoWroteThat/pull/51, but it has been fixed before merging the patch to master. @Mooeypoo discovered it when reviewing the pull request.
Thanks for the update. @HMonroy do the changes also remove the display of 0.0%? If so, I suppose we can move this ticket to QA.
@ifried correct, but this bug was never in "production" since it was discovered during a code review. This also removed the display of 0.0%, and we can move it to QA since https://github.com/wikimedia/WhoWroteThat/pull/51 has been merged.
Great, thanks for the update, @HMonroy! I'm tagging @dom_walden, so he's aware of the status as well.
The original bug (from the task's title and screenshot) appears to be fixed.
However, the two acceptance criteria don't appear to have been addressed. Does this need to go back into the ready column?
You're right, we missed that part when discussing the ticket; it was fixing a code review comment by adding extra functionality.
I have a patch about to go to fix this, so I'm pulling it back -- and fixing the subject line to reflect the actual work.
Acceptance Criteria:
- Always display an integer value for percentage of page written by author (within the revision details pop-up)
We display percentages to 1 decimal place.
- If the value is less than 1%, do not display 0.0%. Rather, display, "Less than 1%."
I have also tested this, and I no longer see the 0.0% displayed. I'm marking this work as Done.