Page MenuHomePhabricator

[ICONS] logout icon horizontal centering
Closed, ResolvedPublic2 Estimated Story Points

Description

The logout icon is misaligned and needs to be shifted to the left.

Screen Shot 2019-09-17 at 5.16.26 PM.png (604×1 px, 77 KB)

I think this has to do with the active state:

Screen Shot 2019-09-17 at 4.48.24 PM.png (132×297 px, 9 KB)

Developer notes

This is actually not a regression from the icon work - it seems to have always been the case.
All menu items have a padding left of 15px to account for the blue bar. Reducing the padding left to 12px makes it look like this:

Screenshot 2019-09-18 at 8.39.11 AM.png (128×275 px, 8 KB)

Screenshot 2019-09-18 at 8.39.14 AM.png (169×286 px, 12 KB)

Is that what's desired?

Event Timeline

ovasileva triaged this task as Medium priority.Sep 18 2019, 9:50 AM

@alexhollender question for you in developer notes

@alexhollender question for you in developer notes

Yup, looks good

Change 538969 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Remove additional padding left on logout button

https://gerrit.wikimedia.org/r/538969

Change 538969 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Remove additional padding left on logout button

https://gerrit.wikimedia.org/r/538969

ovasileva claimed this task.