[ICONS] logout icon horizontal centering
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	• alexhollender_WMF
	Sep 17 2019, 10:13 PM

Description

The logout icon is misaligned and needs to be shifted to the left.

Screen Shot 2019-09-17 at 5.16.26 PM.png (604×1 px, 77 KB)

I think this has to do with the active state:

Screen Shot 2019-09-17 at 4.48.24 PM.png (132×297 px, 9 KB)

Developer notes

This is actually not a regression from the icon work - it seems to have always been the case.
All menu items have a padding left of 15px to account for the blue bar. Reducing the padding left to 12px makes it look like this:

Screenshot 2019-09-18 at 8.39.11 AM.png (128×275 px, 8 KB)

Screenshot 2019-09-18 at 8.39.14 AM.png (169×286 px, 12 KB)

Is that what's desired?

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Remove additional padding left on logout button	mediawiki/skins/MinervaNeue	master	+5 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	ovasileva	T226562 AMC - display labels for toolbar actions on larger screens
Resolved	• alexhollender_WMF	T229440 [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency
Resolved	ovasileva	T233166 [ICONS] logout icon horizontal centering

Event Timeline

• alexhollender_WMF created this task.Sep 17 2019, 10:13 PM

ovasileva triaged this task as Medium priority.Sep 18 2019, 9:50 AM

@alexhollender question for you in developer notes

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-2019-20-Q1) board.Sep 18 2019, 3:52 PM

In T233166#5503382, @Jdlrobson wrote:

@alexhollender question for you in developer notes

Yup, looks good

ovasileva set the point value for this task to 2.Sep 19 2019, 5:38 PM

ovasileva moved this task from Upcoming to Ready for Development on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-2019-20-Q1) board.

Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-2019-20-Q1) board.Sep 24 2019, 8:33 PM

Change 538969 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Remove additional padding left on logout button

https://gerrit.wikimedia.org/r/538969

gerritbot added a project: Patch-For-Review.Sep 24 2019, 8:38 PM

Jdlrobson claimed this task.Sep 24 2019, 8:38 PM

Jdlrobson moved this task from Doing to Needs Code Review on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-2019-20-Q1) board.

Change 538969 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Remove additional padding left on logout button

https://gerrit.wikimedia.org/r/538969

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.25; 2019-10-01).Sep 24 2019, 10:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 24 2019, 10:10 PM

Jdlrobson reassigned this task from Jdlrobson to • alexhollender_WMF.Sep 24 2019, 11:34 PM

Jdlrobson moved this task from Needs Code Review to Needs Design Review on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-2019-20-Q1) board.

Jdlrobson moved this task from Needs triage to MinervaNeue on the Mobile board.Sep 26 2019, 12:12 AM

Checked on beta, looks good.

Screen Shot 2019-09-30 at 10.44.49 AM.png (734×720 px, 26 KB)

ovasileva closed this task as Resolved.Sep 30 2019, 3:24 PM

ovasileva claimed this task.

	F30510007: Screen Shot 2019-09-30 at 10.44.49 AM.png
	Sep 30 2019, 2:45 PM

	F30389586: Screenshot 2019-09-18 at 8.39.14 AM.png
	Sep 18 2019, 3:39 PM

	F30389585: Screenshot 2019-09-18 at 8.39.11 AM.png
	Sep 18 2019, 3:39 PM

	F30382986: Screen Shot 2019-09-17 at 4.48.24 PM.png
	Sep 17 2019, 10:13 PM

	F30382978: Screen Shot 2019-09-17 at 5.16.26 PM.png
	Sep 17 2019, 10:13 PM

[ICONS] logout icon horizontal centeringClosed, ResolvedPublic2 Estimated Story PointsActions