Page MenuHomePhabricator

[Regression pre-wmf.24] Cannot open citation dialog, error in the console "Uncaught TypeError: Cannot read property 'type' of undefined"
Open, Unbreak Now!Public

Description

Steps to reproduce:

  1. Open VE for any page
  2. Click on Cite on the toolbar

Observe that, citation dialog is not opening and the following error appears in the console:
Uncaught TypeError: Cannot read property 'type' of undefined

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 17 2019, 10:40 PM
ppelberg added a comment.EditedSep 17 2019, 10:59 PM

@Ryasmeen is this happening for you consistently? I have not yet been able to reproduce this issue following the steps in the task description.

My configuration

Ryasmeen renamed this task from [Regression wmf.24] Cannot open citation dialog, error in the console "Uncaught TypeError: Cannot read property 'type' of undefined" to [Regression pre-wmf.24] Cannot open citation dialog, error in the console "Uncaught TypeError: Cannot read property 'type' of undefined".Sep 17 2019, 11:01 PM

@ppelberg: This is regression pre-wmf.24, so it's on Beta.

@ppelberg: This is regression pre-wmf.24, so it's on Beta.

Gotcha. Ok. I'm now able to reproduce this. Good spot and thanks for flagging, @Ryasmeen.

ppelberg triaged this task as High priority.Sep 17 2019, 11:06 PM
ppelberg edited projects, added VisualEditor (Current work); removed VisualEditor.
ppelberg raised the priority of this task from High to Unbreak Now!.Sep 17 2019, 11:53 PM

Changing the status considering how this issue blocks a core edit workflow for contributors with no workarounds. Thank you @Ryasmeen for making this clear.

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptSep 17 2019, 11:53 PM

Here's the stack trace:

ve.dm.TreeModifier.js?bfcae:612 Uncaught TypeError: Cannot read property 'type' of undefined
    at VeDmTreeModifier.ve.dm.TreeModifier.processRemove (ve.dm.TreeModifier.js?bfcae:612)
    at VeDmTreeModifier.ve.dm.TreeModifier.processLinearOperation (ve.dm.TreeModifier.js?bfcae:414)
    at VeDmTreeModifier.ve.dm.TreeModifier.calculateTreeOperations (ve.dm.TreeModifier.js?bfcae:391)
    at VeDmTreeModifier.ve.dm.TreeModifier.process (ve.dm.TreeModifier.js?bfcae:356)
    at VeDmTransactionProcessor.ve.dm.TransactionProcessor.process (ve.dm.TransactionProcessor.js?cd715:111)
    at VeDmDocument.ve.dm.Document.commit (ve.dm.Document.js?afe84:341)
    at VeDmSurface.ve.dm.Surface.changeInternal (ve.dm.Surface.js?26ff7:950)
    at VeDmSurface.ve.dm.Surface.popStaging (ve.dm.Surface.js?26ff7:369)
    at VeUiCitoidInspector.<anonymous> (ve.ui.CitoidInspector.js?bccbb:502)
    at Process.js:62

So, looks like it's a TreeModifier side-effect somewhere. @dchan?

matmarex moved this task from Inbox to High Priority on the Editing QA board.Sep 18 2019, 8:00 PM
Ryasmeen edited projects, added Verified; removed Editing QA.