Steps to reproduce:
It says, "Something went wrong", after dismissing the dialog, if I go back to CE, there is no cursor when I click somewhere in that document, so can't make any more edit in that session
@Ryasmeen I seem to be getting a similar, but slightly different version of what you're experiencing...
Actual behavior
❗️"Something went wrong" appears
❗️Nothing happens
Changing the status considering how, in my experience, this issue blocks contributors from saving their edits. Thank you @Ryasmeen for making this clear.
This one was a pain to track, but it's a caught-and-swallowed exception inside TreeModifier. (Swallowed because it occurs in a jQuery promise, where exceptions are discarded.)
Error: Expected
[{"type":"mwTransclusionInline","attributes":{"mw":{"parts":[{"template":{"target":{"wt":"cite journal","href":"./Template:Cite_journal"},"params":{"title":{"wt":"Origin, genetic diversity, and genome structure of the domestic dog."},"author":{"wt":"Wayne, R.K. and Ostrander, E.A."},"journal":{"wt":"BioEssays"},"volume":{"wt":"21"},"pages":{"wt":"247–257"},"url":{"wt":"http://parkinson.cos.ucf.edu/Courses/PCB6677/pdf/bioassay_dog.pdf"},"year":{"wt":"1999"}},"i":0}}]}},"originalDomElementsHash":"hed4d4ce3e5a609c7"},{"type":"/mwTransclusionInline"}]
but got
[{"type":"mwTransclusionInline","attributes":{"mw":{"parts":[{"template":{"target":{"wt":"cite journal","href":"./Template:Cite_journal"},"params":{"title":{"wt":"Origin, genetic diversity, and genome structure of the domestic dog."},"author":{"wt":"Wayne, R.K. and Ostrander, E.A."},"journal":{"wt":"BioEssays"},"volume":{"wt":"21"},"pages":{"wt":"247–257"},"url":{"wt":"http://parkinson.cos.ucf.edu/Courses/PCB6677/pdf/bioassay_dog.pdf"},"year":{"wt":"1999"}},"i":0}}]},"originalMw":"{\"parts\":[{\"template\":{\"target\":{\"wt\":\"cite journal\",\"href\":\"./Template:Cite_journal\"},\"params\":{\"title\":{\"wt\":\"Origin, genetic diversity, and genome structure of the domestic dog.\"},\"author\":{\"wt\":\"Wayne, R.K. and Ostrander, E.A.\"},\"journal\":{\"wt\":\"BioEssays\"},\"volume\":{\"wt\":\"21\"},\"pages\":{\"wt\":\"247–257\"},\"url\":{\"wt\":\"http://parkinson.cos.ucf.edu/Courses/PCB6677/pdf/bioassay_dog.pdf\"},\"year\":{\"wt\":\"1999\"}},\"i\":0}}]}"},"originalDomElementsHash":"h56bf4ce8dae5f62e"},{"type":"/mwTransclusionInline"}]checkEqual (ve.dm.TreeModifier.js?bfcae:291) ve.dm.TreeModifier.static.applyTreeOperation (ve.dm.TreeModifier.js?bfcae:306) ve.dm.TreeModifier.static.applyTreeOperations (ve.dm.TreeModifier.js?bfcae:106) ve.dm.TreeModifier.process (ve.dm.TreeModifier.js?bfcae:358) ve.dm.TransactionProcessor.process (ve.dm.TransactionProcessor.js?cd715:111) ve.dm.Document.commit (ve.dm.Document.js?afe84:341) ve.dm.Surface.changeInternal (ve.dm.Surface.js?26ff7:950) ve.dm.Surface.change (ve.dm.Surface.js?26ff7:918) ve.ui.MWGalleryDialog.insertOrUpdateNode (ve.ui.MWGalleryDialog.js?5dac8:1081) (anonymous) (ve.ui.MWGalleryDialog.js?5dac8:599) (anonymous) (Process.js:62) mightThrow (jquery.js?6fb03:3535) process (jquery.js?6fb03:3603) setTimeout (async) (anonymous) (jquery.js?6fb03:3641) fire (jquery.js?6fb03:3269) add (jquery.js?6fb03:3328) (anonymous) (jquery.js?6fb03:3661) jQuery.Deferred (jquery.migrate.js?cacf7:616) then (jquery.js?6fb03:3646) OO.ui.Process.execute (Process.js:99) OO.ui.Dialog.executeAction (Dialog.js:346) OO.ui.ProcessDialog.executeAction (ProcessDialog.js:222) OO.ui.Dialog.onActionClick (Dialog.js:163) OO.EventEmitter.emit (oojs.jquery.js?f1afe:877) OO.EventEmitter.emit (oojs.jquery.js?f1afe:877) OO.ui.mixin.ButtonElement.onClick (ButtonElement.js:153) dispatch (jquery.js?6fb03:5184) elemData.handle (jquery.js?6fb03:4992)
Seems to have been fixed by @dchan's change https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/537652.