Page MenuHomePhabricator
Create Task
Maniphest T233219

Merge config modules to their parent
Closed, ResolvedPublic
Actions

Description

  • mw.config.values.wbEntityTypes can go to wikibase.ui.entityViewInit
  • mw.config.values.wbGeoShapeStorageApiEndpoint can go to wikibase.ui.entityViewInit
  • mw.config.values.wbDataTypes can go to wikibase.dataTypesStore
  • wikibase.lexeme.config.LexemeLanguageCodePropertyIdConfig into special new lexeme

(Maybe)

  • mw.config.values.wbRefTabsEnabled
  • mw.config.values.wbSiteDetails

Details

SubjectRepoBranchLines +/-
Drop LexemeLanguageCodePropertyIdConfigmediawiki/extensions/WikibaseLexememaster+12 -168
Use package modules instead of mw.config.wbEntityTypesmediawiki/extensions/Wikibasemaster+21 -101
Use mw.config.values.wbGeoShapeStorageApiEndpoint as config.json insteadmediawiki/extensions/Wikibasemaster+12 -13
Customize query in gerrit

Event Timeline

Ladsgroup created this task.Sep 18 2019, 1:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 18 2019, 1:43 PM
Ladsgroup added a comment.Sep 18 2019, 1:44 PM

Note: If the php code that returns the config value is expensive, this needs to be cached. See https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/522613 for more information.

Ladsgroup claimed this task.Sep 23 2019, 9:57 AM
Ladsgroup moved this task from Ready to pick up to Doing on the RL Module Terminators Trailblazing board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptSep 23 2019, 9:57 AM
Ladsgroup updated the task description. (Show Details)Sep 23 2019, 10:08 AM
gerritbot added a comment.Sep 23 2019, 11:53 AM

Change 538596 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Use mw.config.values.wbGeoShapeStorageApiEndpoint as config.json instead

https://gerrit.wikimedia.org/r/538596

gerritbot added a project: Patch-For-Review.Sep 23 2019, 11:53 AM
Ladsgroup moved this task from Doing to Peer Review on the RL Module Terminators Trailblazing board.Sep 23 2019, 9:13 PM
gerritbot added a comment.Sep 24 2019, 12:27 PM

Change 538596 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use mw.config.values.wbGeoShapeStorageApiEndpoint as config.json instead

https://gerrit.wikimedia.org/r/538596

Rosalie_WMDE moved this task from Peer Review to Done on the RL Module Terminators Trailblazing board.Sep 24 2019, 12:32 PM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.24; 2019-09-24).Sep 24 2019, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 24 2019, 1:10 PM
Ladsgroup moved this task from Done to Doing on the RL Module Terminators Trailblazing board.Sep 24 2019, 3:00 PM
gerritbot added a comment.Sep 25 2019, 8:46 PM

Change 539200 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Use package modules instead of mw.config.wbEntityTypes

https://gerrit.wikimedia.org/r/539200

gerritbot added a project: Patch-For-Review.Sep 25 2019, 8:46 PM
Ladsgroup moved this task from Doing to Peer Review on the RL Module Terminators Trailblazing board.Sep 25 2019, 8:51 PM
Ladsgroup moved this task from Peer Review to Doing on the RL Module Terminators Trailblazing board.Sep 26 2019, 11:08 AM
gerritbot added a comment.Sep 26 2019, 11:40 AM

Change 539200 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use package modules instead of mw.config.wbEntityTypes

https://gerrit.wikimedia.org/r/539200

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.25; 2019-10-01); removed MW-1.34-notes (1.34.0-wmf.24; 2019-09-24).Sep 26 2019, 12:01 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 26 2019, 12:10 PM
Ladsgroup updated the task description. (Show Details)Oct 2 2019, 3:59 PM
gerritbot added a comment.Oct 4 2019, 11:28 AM

Change 540844 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/WikibaseLexeme@master] Drop LexemeLanguageCodePropertyIdConfig

https://gerrit.wikimedia.org/r/540844

gerritbot added a project: Patch-For-Review.Oct 4 2019, 11:28 AM
Ladsgroup moved this task from Doing to Peer Review on the RL Module Terminators Trailblazing board.Oct 4 2019, 11:28 AM
Ladsgroup moved this task from Peer Review to Doing on the RL Module Terminators Trailblazing board.Oct 7 2019, 1:03 PM
Ladsgroup removed Ladsgroup as the assignee of this task.Oct 8 2019, 2:27 PM
Ladsgroup moved this task from Doing to Backlog on the RL Module Terminators Trailblazing board.

Most of them is done, the rest can be picked up later.

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Oct 18 2019, 5:32 PM
Ladsgroup moved this task from Incoming to Done on the User-Ladsgroup board.Oct 22 2019, 11:29 AM

We decided there's nothing we can do about it as part of this trailblaze.

gerritbot added a comment.Oct 22 2019, 11:29 AM

Change 540844 abandoned by Ladsgroup:
Drop LexemeLanguageCodePropertyIdConfig

Reason:
Too much work for too little gain. Feel free to pick it up.

https://gerrit.wikimedia.org/r/540844

Ladsgroup moved this task from Backlog to Done on the RL Module Terminators Trailblazing board.Oct 22 2019, 11:36 AM
Maintenance_bot removed a project: Patch-For-Review.Oct 22 2019, 12:10 PM
Ladsgroup closed this task as Resolved.Oct 23 2019, 10:57 AM
Ladsgroup claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL