Page MenuHomePhabricator
Create Task
Maniphest T233228

Style cards to match new design
Closed, ResolvedPublic
Actions

Description

The design for cards with images and suggested tags has evolved and the changes need to be reflected in the working extension. This includes:

  1. Updating styles for the container element to reflect card design (see image below; this has been updated since the mockups/clickable prototype)
  2. Updating suggested tag styles
  3. Updating action elements (e.g. changing X to skip)
  4. De-emphasizing image title

Base state:

2-Suggested tags.png (2×640 px, 969 KB)

With selected tags:

4-Confirmed tags.png (2×640 px, 974 KB)

Details

SubjectRepoBranchLines +/-
Update card styles to match updated designsmediawiki/extensions/MachineVisionmaster+108 -101
Customize query in gerrit

Related Objects
Search...

Event Timeline

AnneT created this task.Sep 18 2019, 3:46 PM
gerritbot added a comment.Sep 19 2019, 3:48 PM

Change 538052 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/MachineVision@master] Update card styles to match updated designs

https://gerrit.wikimedia.org/r/538052

gerritbot added a project: Patch-For-Review.Sep 19 2019, 3:48 PM
gerritbot added a comment.Sep 19 2019, 6:48 PM

Change 538052 merged by jenkins-bot:
[mediawiki/extensions/MachineVision@master] Update card styles to match updated designs

https://gerrit.wikimedia.org/r/538052

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.24; 2019-09-24).Sep 19 2019, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 19 2019, 7:10 PM
egardner moved this task from Incoming to Code Review on the Structured-Data-Backlog (Current Work) board.Sep 19 2019, 7:50 PM
egardner moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
• Mholloway moved this task from Backlog to In development on the MachineVision board.Oct 2 2019, 5:17 PM
AnneT moved this task from In development to Done on the MachineVision board.Oct 15 2019, 8:51 PM
• Ramsey-WMF reassigned this task from AnneT to • PDrouin-WMF.Nov 14 2019, 11:23 PM
• Ramsey-WMF subscribed.

assigning this to Pam for confirmation that we're good here :)

• Ramsey-WMF closed this task as Resolved.Dec 14 2019, 1:33 AM
• Ramsey-WMF moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.

We adjusted the original designs over time and current production reflects that.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL