Page MenuHomePhabricator

Need to write more tests for LinkHandlerUtils.php figureHandler to add coverage
Open, MediumPublic

Description

In working on LinterTest and fixing the erroneous use of stdClass for items in optList, and then converting all usage in LinkHandlerUtils to associative arrays, the full test suite failed to exercise a significant area of figureHandler which had partially fixed code that should have failed but is never exercised. Specifically the section of the function at the bottom where the comment "// ok, sort the new options to match ... " sets up a foreach loop which clearly is not exercised by parserTests. Other small areas of this function also are not being exercised.

Event Timeline

Sbailey created this task.Sep 18 2019, 7:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 18 2019, 7:07 PM
ssastry moved this task from Needs Triage to Testing on the Parsoid board.Jan 22 2020, 7:07 AM
Arlolra triaged this task as Low priority.Feb 14 2020, 7:34 PM
Arlolra raised the priority of this task from Low to Medium.