Page MenuHomePhabricator

Regression: `Cannot read property 'route' of undefined` JS error on all mobile main page
Closed, ResolvedPublicBUG REPORT

Description

Steps to Reproduce:
Visit https://m.mediawiki.org/wiki/MediaWiki or https://he.m.wikipedia.org/wiki/%D7%A2%D7%9E%D7%95%D7%93_%D7%A8%D7%90%D7%A9%D7%99

Causing modest spike on https://grafana.wikimedia.org/d/000000566/overview?panelId=15&fullscreen&orgId=1
Likely to increase with rollout of train tomorrow.
Potentially to overwhelm statsv with unexpected traffic?

Actual Results:
A developer console error

Expected Results:
No developer console error

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 18 2019, 8:28 PM
Jdlrobson renamed this task from `Cannot read property 'route' of undefined` JS error on all mobile main page to Regression: `Cannot read property 'route' of undefined` JS error on all mobile main page.Sep 18 2019, 8:28 PM

Change 537749 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Pass router to showSorryToast

https://gerrit.wikimedia.org/r/537749

Change 537749 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Pass router to showSorryToast

https://gerrit.wikimedia.org/r/537749

Change 537767 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@wmf/1.34.0-wmf.23] Pass router to showSorryToast

https://gerrit.wikimedia.org/r/537767

Change 537767 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@wmf/1.34.0-wmf.23] Pass router to showSorryToast

https://gerrit.wikimedia.org/r/537767

Mentioned in SAL (#wikimedia-operations) [2019-09-18T23:18:33Z] <krinkle@deploy1001> Synchronized php-1.34.0-wmf.23/extensions/MobileFrontend/resources/dist/: T233260, 1667ed957a19067 (duration: 01m 04s)

Jdlrobson closed this task as Resolved.Sep 18 2019, 11:33 PM
Jdlrobson claimed this task.

No longer seeing the JS errors.