Page MenuHomePhabricator
Create Task
Maniphest T233260

Regression: `Cannot read property 'route' of undefined` JS error on all mobile main page
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:
Visit https://m.mediawiki.org/wiki/MediaWiki or https://he.m.wikipedia.org/wiki/%D7%A2%D7%9E%D7%95%D7%93_%D7%A8%D7%90%D7%A9%D7%99

Causing modest spike on https://grafana.wikimedia.org/d/000000566/overview?panelId=15&fullscreen&orgId=1
Likely to increase with rollout of train tomorrow.
Potentially to overwhelm statsv with unexpected traffic?

Actual Results:
A developer console error

Expected Results:
No developer console error

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Pass router to showSorryToastmediawiki/extensions/MobileFrontendwmf/1.34.0-wmf.23+6 -4
Pass router to showSorryToastmediawiki/extensions/MobileFrontendmaster+6 -4
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Sep 18 2019, 8:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 18 2019, 8:28 PM
Jdlrobson renamed this task from `Cannot read property 'route' of undefined` JS error on all mobile main page to Regression: `Cannot read property 'route' of undefined` JS error on all mobile main page.Sep 18 2019, 8:28 PM
gerritbot added a comment.Sep 18 2019, 8:29 PM

Change 537749 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Pass router to showSorryToast

https://gerrit.wikimedia.org/r/537749

gerritbot added a project: Patch-For-Review.Sep 18 2019, 8:29 PM
Jdlrobson added a project: Regression.Sep 18 2019, 8:30 PM
matmarex added a project: MobileFrontend.Sep 18 2019, 9:20 PM
gerritbot added a comment.Sep 18 2019, 9:43 PM

Change 537749 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Pass router to showSorryToast

https://gerrit.wikimedia.org/r/537749

Jdlrobson moved this task from Ready for Development to Ready for Signoff on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-2019-20-Q1) board.Sep 18 2019, 9:47 PM

Possibly need to swat this

gerritbot added a comment.Sep 18 2019, 10:09 PM

Change 537767 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@wmf/1.34.0-wmf.23] Pass router to showSorryToast

https://gerrit.wikimedia.org/r/537767

gerritbot added a comment.Sep 18 2019, 11:12 PM

Change 537767 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@wmf/1.34.0-wmf.23] Pass router to showSorryToast

https://gerrit.wikimedia.org/r/537767

Stashbot added a comment.Sep 18 2019, 11:18 PM

Mentioned in SAL (#wikimedia-operations) [2019-09-18T23:18:33Z] <krinkle@deploy1001> Synchronized php-1.34.0-wmf.23/extensions/MobileFrontend/resources/dist/: T233260, rEMFR1667ed957a19 (duration: 01m 04s)

Jdlrobson closed this task as Resolved.Sep 18 2019, 11:33 PM
Jdlrobson claimed this task.

No longer seeing the JS errors.

Maintenance_bot removed a project: Patch-For-Review.Sep 19 2019, 12:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits