Page MenuHomePhabricator

Urls to auto-generated image variants in ResourceLoader should have 'version' param and long cache-expiry
Closed, ResolvedPublic

Description

Looks like this was regretfully omitted. This apparent mistake has very little impact right now because we almost exclusively embed these variants today.

But, that'll change soon as part of the T121730 experiment (and if positive, would remain that way).

Let's fix this up before we proceed with T121730.

Currently
.oo-ui-icon-bell, .mw-ui-icon-bell:before {
    background-image: url(/w/load.php?modules=oojs-ui.styles.icons-alerts&image=bell&format=rasterized&skin=vector);

    background-image: linear-gradient(transparent,transparent),url(data:image/svg+xml,%3Csvg xmlns=%22…/%3E %3C/svg%3E);
}

Event Timeline

Krinkle created this task.Sep 19 2019, 6:19 PM
Restricted Application added a project: Performance-Team. · View Herald TranscriptSep 19 2019, 6:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Krinkle updated the task description. (Show Details)Sep 19 2019, 6:24 PM
Krinkle triaged this task as High priority.Sep 19 2019, 8:15 PM
Krinkle moved this task from Inbox to Accepted Enhancement on the MediaWiki-ResourceLoader board.

Change 538982 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] resourceloader: Convert ImageModule test to stricter unit test

https://gerrit.wikimedia.org/r/538982

Change 538982 merged by jenkins-bot:
[mediawiki/core@master] resourceloader: Convert ImageModule test to stricter unit test

https://gerrit.wikimedia.org/r/538982

Change 539364 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] [WIP] resourceloader: Add version to ResourceLoaderImage urls for long-cache

https://gerrit.wikimedia.org/r/539364

Change 539375 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] resourceloader: Add $modules parameter to makeVersionQuery()

https://gerrit.wikimedia.org/r/539375

Change 539375 merged by jenkins-bot:
[mediawiki/core@master] resourceloader: Add $modules parameter to makeVersionQuery()

https://gerrit.wikimedia.org/r/539375

Change 539364 merged by jenkins-bot:
[mediawiki/core@master] resourceloader: Add version to ResourceLoaderImage urls for long-cache

https://gerrit.wikimedia.org/r/539364

Krinkle closed this task as Resolved.Sep 30 2019, 1:26 AM