Urls to auto-generated image variants in ResourceLoader should have 'version' param and long cache-expiry
Closed, ResolvedPublic
Actions

Description

Looks like this was regretfully omitted. This apparent mistake has very little impact right now because we almost exclusively embed these variants today.

But, that'll change soon as part of the T121730 experiment (and if positive, would remain that way).

Let's fix this up before we proceed with T121730.

Currently

.oo-ui-icon-bell, .mw-ui-icon-bell:before {
    background-image: url(/w/load.php?modules=oojs-ui.styles.icons-alerts&image=bell&format=rasterized&skin=vector);

    background-image: linear-gradient(transparent,transparent),url(data:image/svg+xml,%3Csvg xmlns=%22…/%3E %3C/svg%3E);
}

Details

Project	Branch	Lines +/-	Subject
mediawiki/core	master	+11 -17	resourceloader: Add version to ResourceLoaderImage urls for long-cache
mediawiki/core	master	+15 -9	resourceloader: Add $modules parameter to makeVersionQuery()
mediawiki/core	master	+22 -11	resourceloader: Convert ImageModule test to stricter unit test

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Krinkle	T121730 Audit use of @embed and remove where not needed (2019)
		Resolved		Krinkle	T233343 Urls to auto-generated image variants in ResourceLoader should have 'version' param and long cache-expiry

Event Timeline

Krinkle created this task.Sep 19 2019, 6:19 PM

Restricted Application added a project: Performance-Team. · View Herald TranscriptSep 19 2019, 6:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Krinkle added a parent task: T121730: Audit use of @embed and remove where not needed (2019).Sep 19 2019, 6:20 PM

Krinkle updated the task description. (Show Details)Sep 19 2019, 6:24 PM

Jdforrester-WMF added a subscriber: Jdforrester-WMF.Sep 19 2019, 6:30 PM

Krinkle triaged this task as High priority.Sep 19 2019, 8:15 PM

Krinkle moved this task from Inbox to Accepted Enhancement on the MediaWiki-ResourceLoader board.

Krinkle claimed this task.Sep 23 2019, 8:13 PM

Krinkle moved this task from Inbox to Backlog: Future Goals on the Performance-Team board.

Krinkle moved this task from Backlog: Future Goals to Next In This Quarter / Oct-Dec 2020 on the Performance-Team board.

Change 538982 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] resourceloader: Convert ImageModule test to stricter unit test

https://gerrit.wikimedia.org/r/538982

gerritbot added a project: Patch-For-Review.Sep 24 2019, 10:49 PM

Change 538982 merged by jenkins-bot:
[mediawiki/core@master] resourceloader: Convert ImageModule test to stricter unit test

https://gerrit.wikimedia.org/r/538982

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.25; 2019-10-01).Sep 25 2019, 7:00 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 25 2019, 7:10 AM

Change 539364 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] [WIP] resourceloader: Add version to ResourceLoaderImage urls for long-cache

https://gerrit.wikimedia.org/r/539364

gerritbot added a project: Patch-For-Review.Sep 26 2019, 4:36 PM

Change 539375 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] resourceloader: Add $modules parameter to makeVersionQuery()

https://gerrit.wikimedia.org/r/539375

Change 539375 merged by jenkins-bot:
[mediawiki/core@master] resourceloader: Add $modules parameter to makeVersionQuery()

https://gerrit.wikimedia.org/r/539375

Krinkle moved this task from Next In This Quarter / Oct-Dec 2020 to Blocked or Needs-CR on the Performance-Team board.Sep 28 2019, 2:00 AM

Change 539364 merged by jenkins-bot:
[mediawiki/core@master] resourceloader: Add version to ResourceLoaderImage urls for long-cache

https://gerrit.wikimedia.org/r/539364

Maintenance_bot removed a project: Patch-For-Review.Sep 28 2019, 9:10 PM

Krinkle closed this task as Resolved.Sep 30 2019, 1:26 AM

Krinkle mentioned this in T121730: Audit use of @embed and remove where not needed (2019).Oct 5 2019, 12:38 AM

Urls to auto-generated image variants in ResourceLoader should have 'version' param and long cache-expiry Closed, ResolvedPublicActions