Page MenuHomePhabricator

ActiveAbstract: remove dependency on pre-MCR database schema
Closed, ResolvedPublic

Description

The extension should not rely on pre-MCR fields in the revision table, and should not assume that the text table is used. Specifically:

  • remove all references to rev_text_id or ar_text_id.
  • remove usages of Revision::getRevisionText()
  • remove reliance on the 'text' flag to Revision::getQueryInfo()

See the parent task(s) for more details.

Care should be taken to maintain backwards compatibility with older versions of MediaWiki, as declared in extension.json.

Event Timeline

daniel created this task.Sep 19 2019, 7:41 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptSep 19 2019, 7:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
daniel updated the task description. (Show Details)Sep 19 2019, 7:45 PM
daniel added a project: ActiveAbstract.
daniel added subscribers: brion, ArielGlenn.

Change 524591 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/ActiveAbstract@master] Remove usages of getRevisionText.

https://gerrit.wikimedia.org/r/524591

daniel claimed this task.Sep 20 2019, 9:16 AM
daniel moved this task from Ready to Blocked on the Core Platform Team Workboards (Purple) board.

Change 524591 merged by jenkins-bot:
[mediawiki/extensions/ActiveAbstract@master] Remove usages of getRevisionText.

https://gerrit.wikimedia.org/r/524591

daniel closed this task as Resolved.Mon, Sep 23, 2:48 PM