Page MenuHomePhabricator

Flow: remove dependency on pre-MCR database schema
Closed, ResolvedPublic

Description

The extension should not rely on pre-MCR fields in the revision table, and should not assume that the text table is used. Specifically:

  • remove all references to rev_text_id or ar_text_id.
  • remove usages of Revision::getRevisionText()
  • remove reliance on the 'text' flag to Revision::getQueryInfo()

See the parent task(s) for more details.

Care should be taken to maintain backwards compatibility with older versions of MediaWiki, as declared in extension.json.

Related Objects

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 538121 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/Flow@master] Remove repair_missing_* maintenance scripts

https://gerrit.wikimedia.org/r/538121

Pchelolo added a subscriber: Pchelolo.

The patch above deals with the only occurrence of *_text_id in the flow extension. Neither getRevisionText nor getQueryInfo with a text flag is present.

Change 538121 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Remove repair_missing_* maintenance scripts

https://gerrit.wikimedia.org/r/538121