ReplaceText: remove dependency on pre-MCR database schema
Closed, ResolvedPublic
Actions

Description

The extension should not rely on pre-MCR fields in the revision table, and should not assume that the text table is used. Specifically:

remove all references to rev_text_id or ar_text_id.
remove usages of Revision::getRevisionText()
remove reliance on the 'text' flag to Revision::getQueryInfo()

See the parent task(s) for more details.

Care should be taken to maintain backwards compatibility with older versions of MediaWiki, as declared in extension.json.

Details

	Subject	Repo	Branch	Lines +/-
	Remove reference to rev_text_id	mediawiki/extensions/ReplaceText	master	+4 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T231668 MCR schema migration
Resolved	Zabe	T231674 [Epic] Remove support for writing to the pre-MCR schema
Resolved	daniel	T198557 Remove the ability to write pre-MCR fields, limit the ability to read pre-MCR fields to migration scripts
Resolved	CCicalese_WMF	T242764 Test schema update from old versions to MCR-only schema
Resolved	daniel	T231673 Make SCHEMA_COMPAT_NEW the default MCR migration schema
Resolved	None	T231672 Stop writing to pre-MCR fields in WMF production
Resolved	None	T231671 [EPIC] Ensure all direct or indirect access to pre-MCR fields is gated with the MCR migration stage and emits a warning if any pre-MCR schema fields are accessed
Resolved	CCicalese_WMF	T231693 No direct or indirect access to pre-MCR fields is ungated
Resolved	daniel	T198341 Remove all references to the rev_text_id and ar_text_id fields
Resolved	• Pchelolo	T198342 Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo().
Resolved	daniel	T198706 Make BackupDumper, WikiExporter and XmlDumpWriter compliant with the MCR revision retrival mechanism (main slot only)
Resolved	BPirkle	T203424 Replace the WikiExporter backup dump streaming mode with batched queries
Resolved	• Clarakosi	T233357 ReplaceText: remove dependency on pre-MCR database schema
Resolved	daniel	T238958 Remove pre-MCR schema fields during update
Resolved	None	T174047 Hide deprecated/unused fields on toolforge replica [MCR]

Event Timeline

daniel created this task.Sep 19 2019, 7:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 19 2019, 7:53 PM

daniel added a parent task: T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo()..Sep 19 2019, 7:53 PM

daniel moved this task from Backlog to Ready on the Platform Team Workboards (Architecture Review Workboard) board.

• Clarakosi claimed this task.Sep 19 2019, 8:15 PM

• Clarakosi moved this task from Ready to Doing on the Platform Team Workboards (Architecture Review Workboard) board.

Change 538264 had a related patch set uploaded (by Clarakosi; owner: Clarakosi):
[mediawiki/extensions/ReplaceText@master] Remove reference to rev_text_id

https://gerrit.wikimedia.org/r/538264

gerritbot added a project: Patch-For-Review.Sep 20 2019, 1:16 PM

• Clarakosi moved this task from Doing to Waiting for Review on the Platform Team Workboards (Architecture Review Workboard) board.Sep 20 2019, 1:48 PM

Change 538264 merged by jenkins-bot:
[mediawiki/extensions/ReplaceText@master] Remove reference to rev_text_id

https://gerrit.wikimedia.org/r/538264

• Clarakosi closed this task as Resolved.Sep 23 2019, 3:05 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 23 2019, 3:10 PM

CCicalese_WMF mentioned this in T198341: Remove all references to the rev_text_id and ar_text_id fields.Oct 21 2019, 6:18 PM

CCicalese_WMF moved this task from Waiting for Review to Done on the Platform Team Workboards (Architecture Review Workboard) board.Nov 1 2019, 10:15 PM