Page MenuHomePhabricator

SpamBlacklist: remove dependency on pre-MCR database schema
Closed, ResolvedPublic

Description

The extension should not rely on pre-MCR fields in the revision table, and should not assume that the text table is used. Specifically:

  • remove all references to rev_text_id or ar_text_id.
  • remove usages of Revision::getRevisionText()
  • remove reliance on the 'text' flag to Revision::getQueryInfo()

See the parent task(s) for more details.

Care should be taken to maintain backwards compatibility with older versions of MediaWiki, as declared in extension.json.

NOTE: RevisionStoreFactory should be used here to get a RevisionStore instance suitable for cross-wiki revision loading!

Event Timeline

daniel created this task.Thu, Sep 19, 8:01 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptThu, Sep 19, 8:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
daniel updated the task description. (Show Details)Thu, Sep 19, 8:02 PM

Change 504797 had a related patch set uploaded (by Daniel Kinzler; owner: BPirkle):
[mediawiki/extensions/SpamBlacklist@master] Remove usage of Revision::GetQueryInfo() with 'text' flag

https://gerrit.wikimedia.org/r/504797

daniel claimed this task.Thu, Sep 19, 8:07 PM

Change 538232 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/SpamBlacklist@master] Support MCR database schema.

https://gerrit.wikimedia.org/r/538232

Change 538232 merged by jenkins-bot:
[mediawiki/extensions/SpamBlacklist@master] Support MCR database schema.

https://gerrit.wikimedia.org/r/538232

Pchelolo closed this task as Resolved.Mon, Sep 23, 6:47 PM

Change 504797 abandoned by Daniel Kinzler:
Remove usage of Revision::GetQueryInfo() with 'text' flag

Reason:
Redundant to I53e218d8d268060b0b81c5c9bab24b7f5a37917a

https://gerrit.wikimedia.org/r/504797