Page MenuHomePhabricator

Mobile VE toolbar doesn't stay onscreen on iOS 13 when keyboard is open
Open, Needs TriagePublic

Description

Mobile VE toolbar doesn't stay onscreen on iOS 13 when keyboard is open.

Instead, it disappears and then flickers unpredictably as you scroll.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSat, Sep 21, 12:06 AM

Change 526235 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] MobileArticleTarget: Limit iOS fixed toolbar workarounds to iOS 12 only

https://gerrit.wikimedia.org/r/526235

ppelberg added a subscriber: ppelberg.EditedTue, Sep 24, 3:15 PM

Great spot, @matmarex. I'm encountering the same issue:

When I scroll an article in edit mode, with the keyboard open, on iOS 13, in Safari, the editing toolbar does not reliably come back into view when I stop scrolling as was this case after we merged the patch in T218414.

I think we should investigate a way to properly present the toolbar when a contributor is scrolling the document in edit mode when they keyboard is visible.

Change 526235 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] MobileArticleTarget: Limit iOS fixed toolbar workarounds to iOS 12 only
https://gerrit.wikimedia.org/r/526235

@matmarex, a couple questions triggered by this part of the patch description: With this patch, on devices running those iOS versions, when you open the keyboard, our edit toolbar will not stay fixed at the top of the screen.

Questions

  • 1. After deploying this patch, on iOS 11 and older, how would a user bring the editing toolbar back into view, when the keyboard is open?
  • 2. After this patch, on iOS 12, how would the toolbar behave when the keyboard is open?
  • 3. After this patch, on iOS 13, how would the toolbar behave when the keyboard is open?
  • 1. After deploying this patch, on iOS 11 and older, how would a user bring the editing toolbar back into view, when the keyboard is open?

Scroll up by about half a screen, until the toolbar scrolls into view again (or close the keyboard).

  • 2. After this patch, on iOS 12, how would the toolbar behave when the keyboard is open?

The same as it does now – the user can scroll it out of view, but it will reappear (slide in) after a moment.

  • 3. After this patch, on iOS 13, how would the toolbar behave when the keyboard is open?

The user can scroll it out of view, and it won't reappear, until you scroll up (or close the keyboard).