Page MenuHomePhabricator

Enqueueing a page marks it as unreviewed without logging it as such
Closed, ResolvedPublicBUG REPORT

Description

Steps to reproduce:

  1. Find any page that has been reviewed
  2. Requeue it

Expected result:
Either

  • The page is requeued as "reviewed", given that it was reviewed and not explicitly unreviewed, or
  • The page is requeued as "unreviewed", and in addition to logging the addition to the queue, the unreviewing is logged

Actual result:

  • The page is requeued as "unreviewed", but no logs to document the unreviewing are generated

Event Timeline

Restricted Application added projects: Growth-Team, User-DannyS712. · View Herald TranscriptSep 22 2019, 4:07 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Until functionality is added to let the user choose if it should be added as reviewed or unreviewed, it should log the unreviewing. Patch coming momemtarily

Change 538409 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PageTriage@master] When requeueing a page, log that the page is unreviewed

https://gerrit.wikimedia.org/r/538409

DannyS712 triaged this task as Medium priority.Sep 22 2019, 4:36 AM

Change 538409 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] When requeueing a page, log that the page is unreviewed

https://gerrit.wikimedia.org/r/538409

@MaxSem given that this is a issue with logging user actions with a feature currently deployed, would it make sense to backport to the current branch live on enwiki?

I don't think it's serious enough to warrant an OOB deploy. Your fix will be live in 2 days in any case, thanks for making it!

dom_walden added a subscriber: dom_walden.

Now, when enqueuing an article (clicking Add to the New Pages Feed), in Special:Log we log the fact that the article's state is unreviewed:

As DannyS712 points out, it will always mark it as unreviewed, regardless of its previous review state. I don't believe we store that state anywhere.

Tested on https://en.wikipedia.beta.wmflabs.org (1.34.0-alpha (c96b835) 14:15, 26 September 2019).

@Barkeep49 @Insertcleverphrasehere These changes should be on production (and thank you, @DannyS712 for the work!). Can you verify that the the requeue behavior is now working properly? Thanks!