Page MenuHomePhabricator

Integration tests shows errors related to special pages
Closed, DeclinedPublic

Description

For https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/GlobalContribs/+/533104/ this happening:

PHPUnit 6.5.14 by Sebastian Bergmann and contributors.
17:34:48 
17:34:49 .............................................................   61 / 1511 (  4%)
17:34:49 .............................................................  122 / 1511 (  8%)
17:34:50 .............................................................  183 / 1511 ( 12%)
17:34:50 .............................................................  244 / 1511 ( 16%)
17:34:51 .............................................................  305 / 1511 ( 20%)
17:34:51 .............................................................  366 / 1511 ( 24%)
17:34:51 .............................................................  427 / 1511 ( 28%)
17:34:51 .............................................................  488 / 1511 ( 32%)
17:34:51 .............................................................  549 / 1511 ( 36%)
17:34:52 .............................................................  610 / 1511 ( 40%)
17:34:52 .............................................................  671 / 1511 ( 44%)
17:34:52 .............................................................  732 / 1511 ( 48%)
17:34:52 .............................................................  793 / 1511 ( 52%)
17:34:52 .............................................................  854 / 1511 ( 56%)
17:34:52 .............................................................  915 / 1511 ( 60%)
17:34:52 .............................................................  976 / 1511 ( 64%)
17:34:52 ............................................................. 1037 / 1511 ( 68%)
17:34:52 ............................................................. 1098 / 1511 ( 72%)
17:34:52 ............................................................. 1159 / 1511 ( 76%)
17:34:53 ............................................................. 1220 / 1511 ( 80%)
17:34:53 ............................................................. 1281 / 1511 ( 84%)
17:34:53 ............................................................. 1342 / 1511 ( 88%)
17:34:53 ............................................................. 1403 / 1511 ( 92%)
17:34:54 E......E...E................................................. 1464 / 1511 ( 96%)
17:34:54 ...............................................               1511 / 1511 (100%)
17:34:54 
17:34:54 You should really fix these slow tests (>50ms)...
17:34:54  1. 175ms to run SpecialPageFatalTest:testSpecialPageDoesNotFatal with data set "Version"
17:34:54  2. 108ms to run AutoLoaderStructureTest:testAutoloadOrder
17:34:54  3. 83ms to run AutoLoaderStructureTest:testAutoLoadConfig
17:34:54  4. 82ms to run SpecialPageFatalTest:testSpecialPageDoesNotFatal with data set "Preferences"
17:34:54  5. 53ms to run SpecialPageFatalTest:testSpecialPageDoesNotFatal with data set "Listgrants"
17:34:54 
17:34:54 
17:34:54 Time: 6.69 seconds, Memory: 106.25MB
17:34:54 
17:34:54 There were 3 errors:
17:34:54 
17:34:54 1) SpecialPageFatalTest::testSpecialPageDoesNotFatal with data set "RunJobs" (SpecialRunJobs Object (...))
17:34:54 === Logs generated by test case
17:34:54 [wfDebug] [debug] IP: 127.0.0.1 {"private":false}
17:34:54 ===
17:34:54 Headers already sent, should send headers earlier than wfHttpError [Called from MediaWiki\HeaderCallback::warnIfHeadersSent in /workspace/src/includes/HeaderCallback.php at line 74]
17:34:54 
17:34:54 /workspace/src/includes/debug/MWDebug.php:333
17:34:54 /workspace/src/includes/debug/MWDebug.php:188
17:34:54 /workspace/src/includes/HeaderCallback.php:74
17:34:54 /workspace/src/includes/libs/HttpStatus.php:104
17:34:54 /workspace/src/includes/GlobalFunctions.php:1661
17:34:54 /workspace/src/includes/specials/SpecialRunJobs.php:50
17:34:54 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:108
17:34:54 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:36
17:34:54 /workspace/src/tests/phpunit/structure/SpecialPageFatalTest.php:33
17:34:54 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:454
17:34:54 /workspace/src/maintenance/doMaintenance.php:99
17:34:54 
17:34:54 2) SpecialPageFatalTest::testSpecialPageDoesNotFatal with data set "JavaScriptTest" (SpecialJavaScriptTest Object (...))
17:34:54 === Logs generated by test case
17:34:54 [wfDebug] [debug] IP: 127.0.0.1 {"private":false}
17:34:54 [wfDebug] [debug] ParserFactory: using preprocessor: Preprocessor_Hash {"private":false}
17:34:54 ===
17:34:54 Cannot modify header information - headers already sent by (output started at /workspace/src/extensions/GlobalContribs/SpecialGlobalEditcount.php:119)
17:34:54 
17:34:54 /workspace/src/includes/specials/SpecialJavaScriptTest.php:195
17:34:54 /workspace/src/includes/specials/SpecialJavaScriptTest.php:53
17:34:54 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:108
17:34:54 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:36
17:34:54 /workspace/src/tests/phpunit/structure/SpecialPageFatalTest.php:33
17:34:54 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:454
17:34:54 /workspace/src/maintenance/doMaintenance.php:99
17:34:54 
17:34:54 3) SpecialPageFatalTest::testSpecialPageDoesNotFatal with data set "GlobalEditcount" (SpecialGlobalEditcount Object (...))
17:34:54 === Logs generated by test case
17:34:54 [wfDebug] [debug] IP: 127.0.0.1 {"private":false}
17:34:54 ===
17:34:54 Error: Call to private method Editcount::extractParameters() from context 'SpecialGlobalEditcount'
17:34:54 
17:34:54 /workspace/src/extensions/GlobalContribs/SpecialGlobalEditcount.php:17
17:34:54 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:108
17:34:54 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:36
17:34:54 /workspace/src/tests/phpunit/structure/SpecialPageFatalTest.php:33
17:34:54 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:454
17:34:54 /workspace/src/maintenance/doMaintenance.php:99
17:34:54 
17:34:54 ERRORS!
17:34:54 Tests: 1511, Assertions: 22090, Errors: 3.

Event Timeline

17:34:54 Error: Call to private method Editcount::extractParameters() from context 'SpecialGlobalEditcount'

Is that extension even working, with a mistyped method name?

17:34:54 Error: Call to private method Editcount::extractParameters() from context 'SpecialGlobalEditcount'

Is that extension even working, with a mistyped method name?

I don't know.