Page MenuHomePhabricator

Flow needs 'editToken' replaced with 'csrfToken'
Closed, ResolvedPublic

Description

Flow needs 'editToken' replaced with 'csrfToken' in a modules/engine/components/board/base/flow-boardandhistory-base.js file.

Event Timeline

Kizule created this task.Sep 22 2019, 3:42 PM
Restricted Application added a project: Performance-Team. · View Herald TranscriptSep 22 2019, 3:45 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 22 2019, 3:57 PM

Change 538426 had a related patch set uploaded (by TheSandDoctor; owner: TheSandDoctor):
[mediawiki/extensions/Flow@master] Flow: Replace deprecated editToken with csrfToken

https://gerrit.wikimedia.org/r/538426

Change 538426 abandoned by TheSandDoctor:
Flow: Replace deprecated editToken with csrfToken

Reason:
Not sure what happened here, but my commit somehow ended up being pushed on master despite my having it set as branch T233526.

https://gerrit.wikimedia.org/r/538426

Change 538426 restored by TheSandDoctor:
Flow: Replace deprecated editToken with csrfToken

Reason:
Restoring per Zoranzoki21.

https://gerrit.wikimedia.org/r/538426

@Zoranzoki21 done. I abandoned as I realized it somehow sent it to master anyways and I thought we were supposed to use our own branch only. Was going to re-push on a branch.

@Zoranzoki21 done. I abandoned as I realized it somehow sent it to master anyways and I thought we were supposed to use our own branch only. Was going to re-push on a branch.

master branch is default on Gerrit, and you did it correct. Own branch is only for local use.

TheSandDoctor triaged this task as Medium priority.Sep 22 2019, 8:27 PM

Change 538426 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Replace deprecated editToken with csrfToken

https://gerrit.wikimedia.org/r/538426

TheSandDoctor closed this task as Resolved.Sep 23 2019, 9:18 PM

@Krinkle This is one of the last remaining WMF deployed ones needing updating. If you think that another task should be made regarding line 46, I can go ahead and create it if you wish. When it comes to addressing it, I guess the first move would be to just remove it and see what happens (if anything) in a test environment(?)