Flow needs 'editToken' replaced with 'csrfToken' in a modules/engine/components/board/base/flow-boardandhistory-base.js file.
Description
Description
Details
Details
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| mediawiki/extensions/Flow | master | +1 -1 | Replace deprecated editToken with csrfToken |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | TheSandDoctor | T233442 Remove use of deprecated 'editToken' in mw.user.tokens (replace with 'csrfToken') | |||
| Resolved | TheSandDoctor | T233526 Flow needs 'editToken' replaced with 'csrfToken' |
Event Timeline
Comment Actions
Change 538426 had a related patch set uploaded (by TheSandDoctor; owner: TheSandDoctor):
[mediawiki/extensions/Flow@master] Flow: Replace deprecated editToken with csrfToken
Comment Actions
Change 538426 abandoned by TheSandDoctor:
Flow: Replace deprecated editToken with csrfToken
Reason:
Not sure what happened here, but my commit somehow ended up being pushed on master despite my having it set as branch T233526.
Comment Actions
Change 538426 restored by TheSandDoctor:
Flow: Replace deprecated editToken with csrfToken
Reason:
Restoring per Zoranzoki21.
Comment Actions
@Zoranzoki21 done. I abandoned as I realized it somehow sent it to master anyways and I thought we were supposed to use our own branch only. Was going to re-push on a branch.
Comment Actions
master branch is default on Gerrit, and you did it correct. Own branch is only for local use.
Comment Actions
Change 538426 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Replace deprecated editToken with csrfToken
Comment Actions
@Krinkle This is one of the last remaining WMF deployed ones needing updating. If you think that another task should be made regarding line 46, I can go ahead and create it if you wish. When it comes to addressing it, I guess the first move would be to just remove it and see what happens (if anything) in a test environment(?)