Page MenuHomePhabricator
Create Task
Maniphest T233528

VisualEditor needs 'editToken' replaced with 'csrfToken'
Closed, ResolvedPublic
Actions

Description

VisualEditor needs 'editToken' replaced with 'csrfToken' in a modules/ve-mw/init/ve.init.mw.Target.js file.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/VisualEditormaster+1 -1VisualEditor: Replace deprecated editToken with csrfToken
Customize query in gerrit

Related Objects
Search...

Event Timeline

Kizule created this task.Sep 22 2019, 3:44 PM
Kizule edited projects, added VisualEditor; removed MediaWiki-ResourceLoader.
Aklapper removed a project: Performance-Team.Sep 22 2019, 3:57 PM
Kizule assigned this task to TheSandDoctor.Sep 22 2019, 4:33 PM
TheSandDoctor added a comment.Sep 22 2019, 5:14 PM

Rebuilding my vagrant to see if that gets rid of the branching issue. Will work on this one asap.

TheSandDoctor added a comment.Sep 22 2019, 5:19 PM
In T233528#5513768, @TheSandDoctor wrote:

Rebuilding my vagrant to see if that gets rid of the branching issue. Will work on this one asap.

Apparently I never noticed that somehow but it was always the case......nevermind.

gerritbot added a comment.Sep 22 2019, 5:23 PM

Change 538429 had a related patch set uploaded (by TheSandDoctor; owner: TheSandDoctor):
[mediawiki/extensions/VisualEditor@master] VisualEditor: Replace deprecated editToken with csrfToken

https://gerrit.wikimedia.org/r/538429

gerritbot added a project: Patch-For-Review.Sep 22 2019, 5:23 PM
TheSandDoctor triaged this task as Medium priority.Sep 22 2019, 8:28 PM
Krinkle closed this task as Resolved.Sep 23 2019, 4:41 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 23 2019, 4:41 AM
gerritbot added a comment.Sep 23 2019, 5:02 AM

Change 538429 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] VisualEditor: Replace deprecated editToken with csrfToken

https://gerrit.wikimedia.org/r/538429

Maintenance_bot removed a project: Patch-For-Review.Sep 23 2019, 5:10 AM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.24; 2019-09-24).Sep 23 2019, 6:00 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL