Page MenuHomePhabricator

CentralNotice needs 'editToken' replaced with 'csrfToken'
Closed, ResolvedPublic

Description

CentralNotice needs 'editToken' replaced with 'csrfToken' in resources/infrastructure/bannereditor.js and resources/infrastructure/ext.centralNotice.adminUi.campaignPager.js per "everything" code search.

Event Timeline

TheSandDoctor updated the task description. (Show Details)

I know to you plan to work on this task, you should when create a task to in assign box set your username. And these two tags are enough, no need much.

TheSandDoctor triaged this task as Low priority.Sun, Sep 22, 8:23 PM
Restricted Application added a project: Performance-Team. · View Herald TranscriptMon, Sep 23, 11:57 AM

Change 538676 had a related patch set uploaded (by TheSandDoctor; owner: TheSandDoctor):
[mediawiki/extensions/CentralNotice@master] CentralNotice: Replace deprecated editToken with csrfToken

https://gerrit.wikimedia.org/r/538676

Change 538676 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] CentralNotice: Replace deprecated editToken with csrfToken

https://gerrit.wikimedia.org/r/538676

TheSandDoctor closed this task as Resolved.Tue, Sep 24, 1:08 AM
TheSandDoctor moved this task from git review pending to merged/done on the User-TheSandDoctor board.
Krinkle reopened this task as Open.Wed, Sep 25, 4:24 PM
Krinkle reassigned this task from TheSandDoctor to AndyRussG.
Krinkle added a project: Fundraising-Backlog.

The CentralNotice extension is special in that it has a separate deployment branch. Keeping this open as reminder for FR-tech to backport, and so that I don't accidentally remove it from core in the parent task seeing this still as open.

Change 539975 had a related patch set uploaded (by AndyRussG; owner: TheSandDoctor):
[mediawiki/extensions/CentralNotice@wmf_deploy] CentralNotice: Replace deprecated editToken with csrfToken

https://gerrit.wikimedia.org/r/539975

Change 539975 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf_deploy] CentralNotice: Replace deprecated editToken with csrfToken

https://gerrit.wikimedia.org/r/539975

Change 539990 had a related patch set uploaded (by Niharika29; owner: TheSandDoctor):
[mediawiki/extensions/CentralNotice@wmf/1.34.0-wmf.24] CentralNotice: Replace deprecated editToken with csrfToken

https://gerrit.wikimedia.org/r/539990

Change 539990 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf/1.34.0-wmf.24] CentralNotice: Replace deprecated editToken with csrfToken

https://gerrit.wikimedia.org/r/539990

Mentioned in SAL (#wikimedia-operations) [2019-09-30T23:28:12Z] <niharika29@deploy1001> Synchronized php-1.34.0-wmf.24/extensions/CentralNotice/resources/infrastructure/: CentralNotice: Replace deprecated editToken with csrfToken - T233538 (duration: 00m 57s)

Krinkle closed this task as Resolved.Tue, Oct 1, 4:21 PM