| DannyS712 | |
| Sep 22 2019, 8:36 PM |
| F30437283: Screenshot 2019-09-22 at 22.13.30.png | |
| Sep 22 2019, 9:13 PM |
Steps to Reproduce:
Actual Results:
Unhandled Exception ("AphrontParameterQueryException")
Array for %Ls conversion is empty. Query: badges.phid IN (%Ls)Expected Results:
Badge is awarded
As this has been pointed that it's due to lack of necessary permission T233541#5514334, the expected result should be a nice permission error message
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | BUG REPORT | Aklapper | T233541 Unhandled Exception when clicking "Award" without choosing a badge; No badge type-ahead proposals if no permission to award badges | ||
| Resolved | brennen | T370266 Update to Phorge upstream 2024.35 release | |||
| Resolved | Marostegui | T390034 Prepare a database test for m3 | |||
| Resolved | ABran-WMF | T397886 PuppetDisabled - phab1005:9100 | |||
| Resolved | Pppery | T399604 Update Phabricator translations to 2024.35 release |
No idea. I have phab admin, it worked. You don't, and it didn't... :)
It's not well documented
I added a little note at Phabricator/Help#Phabricator_Badges. Only phabricator admins can award badges, and this is intentional if I recall correctly. The restriction is set when the badges are created.
Trying to hand out a badge with my volunteer Phab account, I don't even get a list of badges. I only get back for (;;);{"error":null,"payload":[]} after type-ahead. To be explicit, this error is about leaving the Badge field empty (=not waiting for autocomplete proposals), and then clicking the Award button.
So there are two issues here. I can reproduce both of them in upstream.
Steps to reproduce:
Expected outcome:
An informational error message
Actual outcome:
Unhandled Exception ("AphrontParameterQueryException")
Array for %Ls conversion is empty. Query: badges.phid IN (%Ls)The exception was fixed in upstream rPHAB43d3fd9eac6e (and another one in rPHAB8793bdbaa87c).
As this has been pointed that it's due to lack of necessary permission T233541#5514334, the expected result should be a nice permission error message
In my understanding people have generally permission to award badges but none of the badges allows that. So the current behavior might look confusing but makes sense to me. In any case, that's a different issue about permissions and not about fixing code - please move that to a separate ticket. Thanks!