Page MenuHomePhabricator
Create Task
Maniphest T233545

TinyMCE needs 'editToken' replaced with 'csrfToken'
Closed, ResolvedPublic
Actions

Description

TinyMCE needs 'editToken' replaced with 'csrfToken' in tinymce/plugins/mw_paste/plugin.js and tinymce/plugins/mw_upload/plugin.js per "everything" code search.

Details

SubjectRepoBranchLines +/-
TinyMCE: Replace deprecated editToken with csrfTokenmediawiki/extensions/TinyMCEmaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

TheSandDoctor triaged this task as Low priority.Sep 22 2019, 9:26 PM
TheSandDoctor created this task.
Reedy removed a project: Performance-Team.Sep 22 2019, 9:58 PM
TheSandDoctor added a project: User-TheSandDoctor.Sep 23 2019, 6:43 AM
gerritbot added a comment.Sep 23 2019, 5:06 PM

Change 538674 had a related patch set uploaded (by TheSandDoctor; owner: TheSandDoctor):
[mediawiki/extensions/TinyMCE@master] TinyMCE: Replace deprecated editToken with csrfToken

https://gerrit.wikimedia.org/r/538674

gerritbot added a project: Patch-For-Review.Sep 23 2019, 5:06 PM
TheSandDoctor moved this task from Backlog to git review pending on the User-TheSandDoctor board.Sep 23 2019, 5:06 PM
TheSandDoctor changed the task status from Open to Stalled.Oct 20 2019, 6:57 AM
TheSandDoctor added a subscriber: Yaron_Koren.Dec 30 2019, 5:27 AM

@Yaron_Koren could you please take a look at this?

TheSandDoctor added a comment.Feb 22 2020, 1:49 AM

@Yaron_Koren could you please take a look?

Krinkle unsubscribed.Feb 23 2020, 5:31 PM
gerritbot added a comment.Apr 12 2020, 7:24 AM

Change 538674 merged by jenkins-bot:
[mediawiki/extensions/TinyMCE@master] TinyMCE: Replace deprecated editToken with csrfToken

https://gerrit.wikimedia.org/r/538674

Maintenance_bot removed a project: Patch-For-Review.Apr 12 2020, 8:10 AM
Aklapper mentioned this in rETMC7e9dbb0b627e: TinyMCE: Replace deprecated editToken with csrfToken.Apr 12 2020, 9:02 AM
TheSandDoctor closed this task as Resolved.Apr 25 2020, 4:14 AM
TheSandDoctor raised the priority of this task from Low to High.
TheSandDoctor moved this task from git review pending to merged/done on the User-TheSandDoctor board.

Thanks for merging this @Aklapper !

Aklapper added a comment.Apr 25 2020, 10:06 AM

Heh, I did not merge (+2) it but Umherirrender, I think :)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL