Page MenuHomePhabricator
Create Task
Maniphest T233597

Refactor ApiMain to use OutputPage::sendCacheControl
Closed, DeclinedPublic
Actions

Description

Reduce code duplication by reusing OutputPage::sendCacheControl from ApiMain::sendCacheHeaders.

Details

SubjectRepoBranchLines +/-
Refactor ApiMain to use OutputPage::sendCacheControlmediawiki/coremaster+30 -55
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tchanders created this task.Sep 23 2019, 10:05 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 23 2019, 10:05 AM
Tchanders renamed this task from Refactor ApiMAin to use OutputPage::sendCacheControl to Refactor ApiMain to use OutputPage::sendCacheControl.Sep 23 2019, 10:05 AM
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.
dbarratt moved this task from Code Review 🔍 to In Progress 💪 on the Anti-Harassment (The Letter Song) board.Oct 5 2019, 4:24 AM
dbarratt added a subtask: T196575: Add block cookie for browser-based API edits (including VisualEditor & MobileFrontend).Oct 5 2019, 3:33 PM
dbarratt edited projects, added MediaWiki-Action-API; removed Anti-Harassment (The Letter Song).Oct 10 2019, 3:08 PM
Restricted Application added a project: Platform Engineering. · View Herald TranscriptOct 10 2019, 3:08 PM
gerritbot added a comment.Oct 10 2019, 3:11 PM

Change 542134 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/core@master] Refactor ApiMain to use OutputPage::sendCacheControl

https://gerrit.wikimedia.org/r/542134

gerritbot added a project: Patch-For-Review.Oct 10 2019, 3:11 PM
Anomie moved this task from Unsorted to Needs Review on the MediaWiki-Action-API board.Oct 10 2019, 3:13 PM
Anomie edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.
Anomie moved this task from Inbox to External Code Review Needed on the Platform Team Workboards (Clinic Duty Team) board.
dbarratt closed subtask T196575: Add block cookie for browser-based API edits (including VisualEditor & MobileFrontend) as Resolved.Oct 15 2019, 2:26 PM
dbarratt removed dbarratt as the assignee of this task.Oct 25 2019, 6:41 PM
dbarratt subscribed.
dbarratt mentioned this in T236751: Allow OutputPage to set maxage.Oct 29 2019, 2:58 AM
• mobrovac moved this task from External Code Review Needed to Blocked Externally on the Platform Team Workboards (Clinic Duty Team) board.Nov 12 2019, 11:11 AM
WDoranWMF moved this task from Blocked Externally to External Code Review Completed on the Platform Team Workboards (Clinic Duty Team) board.Mar 24 2020, 8:25 PM
gerritbot added a comment.Jan 28 2021, 4:39 AM

Change 542134 abandoned by Krinkle:
[mediawiki/core@master] Refactor ApiMain to use OutputPage::sendCacheControl

Reason:
Closing for now as original issue was addressed in other commits that have landed, and this area currently has no active steward to resource refactoring changes like these. The trade-off between re-use and locality is unclear to me here, but I'm slightly leaning toward keeping it local/inlined for easier maintenance within the API code.

https://gerrit.wikimedia.org/r/542134

Krinkle closed this task as Declined.Jan 28 2021, 4:39 AM
Krinkle closed subtask T236751: Allow OutputPage to set maxage as Declined.Jan 29 2021, 1:36 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL