Page MenuHomePhabricator

Refactor ApiMain to use OutputPage::sendCacheControl
Closed, DeclinedPublic

Description

Reduce code duplication by reusing OutputPage::sendCacheControl from ApiMain::sendCacheHeaders.

Event Timeline

Tchanders renamed this task from Refactor ApiMAin to use OutputPage::sendCacheControl to Refactor ApiMain to use OutputPage::sendCacheControl.Sep 23 2019, 10:05 AM

Change 542134 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/core@master] Refactor ApiMain to use OutputPage::sendCacheControl

https://gerrit.wikimedia.org/r/542134

dbarratt added a subscriber: dbarratt.

Change 542134 abandoned by Krinkle:
[mediawiki/core@master] Refactor ApiMain to use OutputPage::sendCacheControl

Reason:
Closing for now as original issue was addressed in other commits that have landed, and this area currently has no active steward to resource refactoring changes like these. The trade-off between re-use and locality is unclear to me here, but I'm slightly leaning toward keeping it local/inlined for easier maintenance within the API code.

https://gerrit.wikimedia.org/r/542134