Page MenuHomePhabricator

Deploy Advanced mode to all Wikimedia projects
Open, NormalPublic2 Story Points

Description

Background

We performed an audit of all Wikimedia projects and would like to deploy advanced mode to all projects where we believe it might be helpful

User story

As a regular contributor on Wikimedia Commons, I would like to use desktop (advanced) features on the mobile site.

Acceptance Criteria

  • Deploy AMC to all Wikimedia projects
  • Remove AMC feature flagging

QA instructions

  • For each of the following projects, check the features listed
wikis

Mediawiki
Wiktionary
Commons
Wikinews
Wikiquote
Wikidata
Wikivoyage
Wikisource
Wikispecies
Wikiversity
Wikibooks

features (all items appear and function as expected)

article/talk tabs
main menu
user menu
actions menu
overflow menu
history page
recent changes

NOTE: only need screenshots if something is broken

QA Results

AC#wikiarticle/talk tabsmain menuuser menuactions menuoverflow menuhistory pagerecent changesdetails
AC1MediawikiT233612#5588424
AC2WiktionaryT233612#5588424
AC3CommonsT233612#5588424
AC4WikinewsT233612#5588424
AC5WikiquoteT233612#5588424
AC6WikidataT233612#5588424
AC7WikivoyageT233612#5588424
AC8WikisourceT233612#5588424
AC9WikispeciesT233612#5588424
AC10WikiversityT233612#5588424
AC11WikibooksT233612#5588424

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMon, Sep 23, 11:32 AM
ovasileva moved this task from Incoming to Needs Prioritization on the Readers-Web-Backlog board.
ovasileva renamed this task from Deploy Advanced mode to Wikimedia Commons to Deploy Advanced mode to most Wikimedia projects.Wed, Oct 2, 8:44 AM
ovasileva triaged this task as Normal priority.
ovasileva updated the task description. (Show Details)
ovasileva removed ovasileva as the assignee of this task.Wed, Oct 2, 5:04 PM
ovasileva added a subscriber: ovasileva.

@ovasileva enabling for all wikis would make life a lot easier from a maintenance point of view.
Having different wikis running different setups puts us at risk of exposing bugs (and missing them) on smaller wikis as we are unlikely to be testing the scenario "project with AMC disabled". I urge you to consider making this the default for all wikis...

Masumrezarock100 added a comment.EditedThu, Oct 3, 5:59 PM

@ovasileva enabling for all wikis would make life a lot easier from a maintenance point of view.
Having different wikis running different setups puts us at risk of exposing bugs (and missing them) on smaller wikis as we are unlikely to be testing the scenario "project with AMC disabled". I urge you to consider making this the default for all wikis...

Yeah it's better to deploy it to all Wikimedia projects. No point in keeping this mode restricted to some wikis. Hey I have an idea. Why not make advanced mode a opt-out feature? Make it a default setting and rename the original mobile version to something like "Simple mode".

@ovasileva enabling for all wikis would make life a lot easier from a maintenance point of view.
Having different wikis running different setups puts us at risk of exposing bugs (and missing them) on smaller wikis as we are unlikely to be testing the scenario "project with AMC disabled". I urge you to consider making this the default for all wikis...

Ok, let's turn it on everywhere, although my fear is that on the projects that were excluded from the original list, AMC will not be particularly helpful.

ovasileva renamed this task from Deploy Advanced mode to most Wikimedia projects to Deploy Advanced mode to all Wikimedia projects.Wed, Oct 9, 11:37 AM
ovasileva updated the task description. (Show Details)
ovasileva set the point value for this task to 2.Wed, Oct 9, 4:09 PM
pmiazga updated the task description. (Show Details)Wed, Oct 9, 4:10 PM

Change 541953 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[operations/mediawiki-config@master] Enable AMC everywhere

https://gerrit.wikimedia.org/r/541953

Change 541953 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable AMC everywhere

https://gerrit.wikimedia.org/r/541953

Mentioned in SAL (#wikimedia-operations) [2019-10-09T23:24:21Z] <catrope@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Enable AMC on all wikis (T233612) (duration: 00m 58s)

Cool, I just enabled advanced mode on Commons, and the modal looks perfect!

@Johan Would it be possible to announce it in the next Tech news?

Johan added a comment.Thu, Oct 10, 5:24 PM

When more exactly will it be deployed to all wikis? We had a mention of it in #29 but should update again once all wikis have it, of course.

When more exactly will it be deployed to all wikis? We had a mention of it in #29 but should update again once all wikis have it, of course.

It appears that it already has been deployed to all Wikimedia projects. I can now enable this mode on Mediawiki, Wikimedia Commons, and other Wikimedia sites.

ovasileva updated the task description. (Show Details)Thu, Oct 10, 6:17 PM
Johan added a comment.Thu, Oct 10, 7:10 PM

OK, added.

ovasileva reassigned this task from Jdlrobson to Edtadros.Mon, Oct 14, 5:34 PM
Edtadros reassigned this task from Edtadros to ovasileva.Sat, Oct 19, 2:45 AM
Edtadros added a subscriber: Edtadros.

Test Result

Status: See table below
OS: macOS Mojave
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

AC#wikiarticle/talk tabsmain menuuser menuactions menuoverflow menuhistory pagerecent changesmiscellanous observation(s)
AC1Mediawiki⬜Main menu partial overlay
AC2WiktionaryMain menu partial overlay. The word of the day boxes are cut off on the right.
AC3Commons⬜ Main menu partial overlay
AC4Wikinews⬜ Main menu partial overlay
AC5WikiquoteThe Welcome and intro panels are cut off on the right.
AC6Wikidata❌ The overflow is to the left of the watchstar.
Main menu partial overlay. The Welcome text is truncated on the bottom. Towards the ottom the Wikimedia Family icons are no all aligned and the longer text is truncated.
AC7Wikivoyage⬜Main menu FULL overlay
AC8Wikisource⬜ Main menu partial overlay
AC9Wikispecies⬜ Main menu FULL overlay
AC10WikiversityMain menu partial overlay. The Wikiversity's sister projects panel is cut off on the right.
AC11Wikibooks⬜ Main menu partial overlay

@ovasileva The only issue is the location of the overflow menu (AC6 above). I also noticed that the main menu overlay sometimes takes the whole screen (FULL), and sometimes is partial only. I noted that in the Miscellaneous observations column along with some other issues not related to this ticket.

Edtadros updated the task description. (Show Details)Sat, Oct 19, 2:49 AM
Edtadros updated the task description. (Show Details)
Edtadros updated the task description. (Show Details)

For wikidata I've spun out T236091 as there is an override of default behaviour in an extension we do not own.