Page MenuHomePhabricator

Use assert=user instead of assertuser=<username>
Closed, DeclinedPublic

Description

Per https://www.mediawiki.org/wiki/API:Login#Additional_notes we can verify that some user is logged in (without matching the user name) via assert=user in API requests. This should "prevent leaking IP addresses during editing" work for logged in user on setups that do not support central auth while still allowing for the user (name) to diverge.

AC

  • in ForeignApiWritingRepository use assert=user instead of assertuser=<username>
  • conditionally send it depending on whether the user is logged in on the client

Event Timeline

This is how I understood what we said earlier - please verify.
IMO it still has the flaw that it implicitly assumes that "logged in" expects "logged in" - it is the right thing to do for CentralAuth wikis but intransparent otherwise.

Closing based on discussion with @Lucas_Werkmeister_WMDE. The current state is fine it seems.

Lucas_Werkmeister_WMDE changed the task status from Resolved to Declined.Dec 9 2019, 1:06 PM