Page MenuHomePhabricator

Settings should be in an overlay
Open, MediumPublic

Description

Description

Currently after navigating to settings you need to press the back button 1–2 times in order to return to where you were. This is an awkward process because it's unclear if pressing back will somehow undo the settings change you just made, also it might not occur to you to do this in order to get back to where you were. Opening Settings in an overlay would be a better experience.

mobiledesktop

related: T230354

Event Timeline

  • Would we still fall back to the old page for non javascript users?
  • how would it be opened?
  • if from the main menu would closing the overlay show the menu open?

I like this one, but please keep the old version for non-javascript users.

  • Would we still fall back to the old page for non javascript users?
  • how would it be opened?
  • if from the main menu would closing the overlay show the menu open?
  • yes I assume we have to keep the old page for non-JS
  • it would be opened from the main menu. Upon clicking the "Settings" menu item the menu would slide shut as the modal opens. Upon closing the settings modal the main menu would not be open.

t would be opened from the main menu. Upon clicking the "Settings" menu item the menu would slide shut as the modal opens. Upon closing the settings modal the main menu would not be open.

Does this mean the main menu animates and closes before the overlay opens or does it happen behind the overlay? Is it possible to mock that experience? I think understanding that transition will be important for estimating this.

it would be opened from the main menu. Upon clicking the "Settings" menu item the menu would slide shut as the modal opens. Upon closing the settings modal the main menu would not be open.

Does this mean the main menu animates and closes before the overlay opens or does it happen behind the overlay? Is it possible to mock that experience? I think understanding that transition will be important for estimating this.

Either way is fine, whatever is easier. I was imagining it like this, but if the menu drawer closes in the background that works fine.

ovasileva triaged this task as Medium priority.Oct 2 2019, 8:47 AM
ovasileva moved this task from Incoming to Triaged but Future on the Readers-Web-Backlog board.

We may need these kind of settings for desktop too, so when we work on desktop refresh we might want to consider doing this and applying it to mobile mobile and desktop rather than maintaining 2 different implementations.

Depending on the approach taken, this task may be a good candidate for initial FAWG integration (it's a form composed of components with minimal ties to MW and may appear as a modal).

Sounds good to me. I think this is also a good example where we shouldn't support non-JS users (especially after dropping beta). We should aim to unify logic between any newly proposed desktop settings and the mobile logic.