Homepage: Impact module - tooltip text is aligned right
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Sep 25 2019, 12:09 AM

Description

On the Homepage Impact module (testwiki wmf.24), the tooltip text is aligned right:

growthexperiments-homepage-module-impact .impact-row .pageviews, .growthexperiments-homepage-module-impact .impact-row .empty-pageviews {
    display: table-cell;
    vertical-align: middle;
    text-align: right;

Screen Shot 2019-09-24 at 4.53.06 PM.png (266×422 px, 32 KB)

Change to text-align: left; per standard tooltip display:

Screen Shot 2019-09-24 at 5.00.26 PM.png (316×425 px, 33 KB)

Another example - RC tooltips for filters:

Screen Shot 2019-09-24 at 5.05.46 PM.png (146×394 px, 20 KB)

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Homepage: Impact module - fix tooltip text alignment	mediawiki/extensions/GrowthExperiments	master	+1 -1

Customize query in gerrit

Event Timeline

Etonkovidova created this task.Sep 25 2019, 12:09 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2019, 12:09 AM

Etonkovidova moved this task from Inbox to Upcoming Work on the Growth-Team board.Sep 25 2019, 4:52 PM

Etonkovidova moved this task from Upcoming Work to Q1 2019-20 on the Growth-Team board.Sep 25 2019, 6:01 PM

Etonkovidova moved this task from Q1 2019-20 to Sprint 0 (Growth Team) on the Growth-Team board.Sep 25 2019, 6:04 PM

Etonkovidova edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.

JTannerWMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Oct 15 2019, 2:35 PM

MMiller_WMF edited projects, added Growth-Team; removed Growth-Team (Sprint 0 (Growth Team)).Nov 13 2019, 7:44 AM

MMiller_WMF moved this task from Inbox to Upcoming Work on the Growth-Team board.

RHo updated the task description. (Show Details)Jan 22 2021, 10:50 AM

• mewoph claimed this task.Jan 27 2021, 6:00 PM

• mewoph edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.

MMiller_WMF awarded a token.Jan 27 2021, 6:56 PM

Change 659452 had a related patch set uploaded (by MewOphaswongse; owner: MewOphaswongse):
[mediawiki/extensions/GrowthExperiments@master] Homepage: Impact module - fix tooltip text alignment

https://gerrit.wikimedia.org/r/659452

gerritbot added a project: Patch-For-Review.Jan 28 2021, 11:15 PM

After:

Also verified in AR to make sure text is still RTL

@mewoph -- now that your patch is up, I'm moving the task to the "Code Review" column of our sprint board so that another engineer can review it.

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 29 2021, 3:50 PM

Change 659452 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Homepage: Impact module - fix tooltip text alignment

https://gerrit.wikimedia.org/r/659452

Maintenance_bot removed a project: Patch-For-Review.Jan 29 2021, 4:10 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.29; 2021-02-02).Jan 29 2021, 5:00 PM

Checked in betalabs ( did crossbrowser testing too). Added to my list of tasks to re-check after deployment.

kostajh awarded a token.Jan 30 2021, 3:52 PM

	F30459105: Screen Shot 2019-09-24 at 5.00.26 PM.png
	Sep 25 2019, 12:09 AM

	F30459087: Screen Shot 2019-09-24 at 4.53.06 PM.png
	Sep 25 2019, 12:09 AM

	F30459134: Screen Shot 2019-09-24 at 5.05.46 PM.png
	Sep 25 2019, 12:09 AM

	F34056339: tooltip_ar.png
	Jan 28 2021, 11:18 PM

	F34056340: tooltip_fixed.jpg
	Jan 28 2021, 11:18 PM

Homepage: Impact module - tooltip text is aligned rightClosed, ResolvedPublicActions

Description

Details

Event Timeline

Homepage: Impact module - tooltip text is aligned right
Closed, ResolvedPublic
Actions