Page MenuHomePhabricator

Homepage: Impact module - tooltip text is aligned right
Closed, ResolvedPublic

Description

On the Homepage Impact module (testwiki wmf.24), the tooltip text is aligned right:

growthexperiments-homepage-module-impact .impact-row .pageviews, .growthexperiments-homepage-module-impact .impact-row .empty-pageviews {
    display: table-cell;
    vertical-align: middle;
    text-align: right;

Screen Shot 2019-09-24 at 4.53.06 PM.png (266×422 px, 32 KB)

Change to text-align: left; per standard tooltip display:
Screen Shot 2019-09-24 at 5.00.26 PM.png (316×425 px, 33 KB)

Another example - RC tooltips for filters:
Screen Shot 2019-09-24 at 5.05.46 PM.png (146×394 px, 20 KB)

Event Timeline

Change 659452 had a related patch set uploaded (by MewOphaswongse; owner: MewOphaswongse):
[mediawiki/extensions/GrowthExperiments@master] Homepage: Impact module - fix tooltip text alignment

https://gerrit.wikimedia.org/r/659452

After:

tooltip_fixed.jpg (505×865 px, 68 KB)

Also verified in AR to make sure text is still RTL

tooltip_ar.png (500×963 px, 60 KB)

@mewoph -- now that your patch is up, I'm moving the task to the "Code Review" column of our sprint board so that another engineer can review it.

Change 659452 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Homepage: Impact module - fix tooltip text alignment

https://gerrit.wikimedia.org/r/659452

Checked in betalabs ( did crossbrowser testing too). Added to my list of tasks to re-check after deployment.