Page MenuHomePhabricator
Create Task
Maniphest T233790

Untangle datamodel dependency tree
Closed, ResolvedPublic
Actions

Description

Details

SubjectRepoBranchLines +/-
Remove global access to Wikibase datamodel in jsmediawiki/extensions/Citoidmaster+37 -26
Drop all of wikibase.datamodel except the main entry pointmediawiki/extensions/Wikibasemaster+15 -361
Remove global access to Wikibase datamodel in jsmediawiki/extensions/UploadWizardmaster+22 -14
Remove global access to Wikibase datamodel in jsmediawiki/extensions/WikibaseMediaInfomaster+410 -269
Avoid usage of global wikibase.datamodel namespacemediawiki/extensions/WikibaseMediaInfomaster+18 -19
Remove not needed datamodel dependencymediawiki/extensions/WikibaseLexememaster+0 -1
Use 'wikibase.datamodel' as the only datamodel RL modulemediawiki/extensions/WikibaseLexememaster+95 -75
Use 'wikibase.datamodel' as the only datamodel RL modulemediawiki/extensions/Wikibasemaster+714 -636
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jakob_WMDE created this task.Sep 25 2019, 9:55 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2019, 9:55 AM
Jakob_WMDE claimed this task.Sep 25 2019, 9:55 AM
Jakob_WMDE moved this task from Backlog to Doing on the RL Module Terminators Trailblazing board.
gerritbot added a comment.Oct 1 2019, 11:26 AM

Change 540101 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Use 'wikibase.datamodel' as the only datamodel RL module

https://gerrit.wikimedia.org/r/540101

gerritbot added a project: Patch-For-Review.Oct 1 2019, 11:26 AM
gerritbot added a comment.Oct 2 2019, 10:37 AM

Change 540101 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use 'wikibase.datamodel' as the only datamodel RL module

https://gerrit.wikimedia.org/r/540101

Maintenance_bot removed a project: Patch-For-Review.Oct 2 2019, 11:10 AM
gerritbot added a comment.Oct 2 2019, 1:13 PM

Change 540405 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Use 'wikibase.datamodel' as the only datamodel RL module

https://gerrit.wikimedia.org/r/540405

gerritbot added a project: Patch-For-Review.Oct 2 2019, 1:13 PM
gerritbot added a comment.Oct 2 2019, 4:09 PM

Change 540405 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Use 'wikibase.datamodel' as the only datamodel RL module

https://gerrit.wikimedia.org/r/540405

Maintenance_bot removed a project: Patch-For-Review.Oct 2 2019, 4:10 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.1; 2019-10-08).Oct 2 2019, 5:00 PM
Ladsgroup subscribed.Oct 4 2019, 10:52 AM

BTW. Looking at current graph of Wikibase dependencies, it's very obvious how much this work is needed:

G.png (2×10 px, 2 MB)

Jakob_WMDE updated the task description. (Show Details)Oct 7 2019, 10:25 AM
gerritbot added a comment.Oct 7 2019, 10:25 AM

Change 541216 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Remove not needed datamodel dependency

https://gerrit.wikimedia.org/r/541216

gerritbot added a project: Patch-For-Review.Oct 7 2019, 10:25 AM
gerritbot added a comment.Oct 7 2019, 11:21 AM

Change 541229 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseMediaInfo@master] Avoid usage of global wikibase.datamodel namespace

https://gerrit.wikimedia.org/r/541229

gerritbot added a comment.Oct 7 2019, 11:53 AM

Change 541216 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Remove not needed datamodel dependency

https://gerrit.wikimedia.org/r/541216

gerritbot added a comment.Oct 7 2019, 2:40 PM

Change 541229 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Avoid usage of global wikibase.datamodel namespace

https://gerrit.wikimedia.org/r/541229

Maintenance_bot removed a project: Patch-For-Review.Oct 7 2019, 3:10 PM
gerritbot added a comment.Oct 8 2019, 2:59 PM

Change 541553 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseMediaInfo@master] Remove global access to Wikibase datamodel in js

https://gerrit.wikimedia.org/r/541553

gerritbot added a project: Patch-For-Review.Oct 8 2019, 2:59 PM
Jakob_WMDE removed Jakob_WMDE as the assignee of this task.Oct 9 2019, 1:27 PM
Jakob_WMDE updated the task description. (Show Details)
Jakob_WMDE moved this task from Doing to Ready to pick up on the RL Module Terminators Trailblazing board.
Jakob_WMDE updated the task description. (Show Details)Oct 10 2019, 10:07 AM
Jakob_WMDE claimed this task.Oct 10 2019, 10:28 AM
Jakob_WMDE moved this task from Ready to pick up to Doing on the RL Module Terminators Trailblazing board.
gerritbot added a comment.Oct 10 2019, 10:37 AM

Change 541553 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Remove global access to Wikibase datamodel in js

https://gerrit.wikimedia.org/r/541553

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.2; 2019-10-15); removed MW-1.35-notes (1.35.0-wmf.1; 2019-10-08).Oct 10 2019, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Oct 10 2019, 11:10 AM
gerritbot added a comment.Oct 14 2019, 11:37 AM

Change 542902 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Citoid@master] Remove global access to Wikibase datamodel in js

https://gerrit.wikimedia.org/r/542902

gerritbot added a project: Patch-For-Review.Oct 14 2019, 11:37 AM
Jakob_WMDE updated the task description. (Show Details)Oct 14 2019, 3:16 PM
gerritbot added a comment.Oct 14 2019, 3:58 PM

Change 540382 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/UploadWizard@master] Remove global access to Wikibase datamodel in js

https://gerrit.wikimedia.org/r/540382

Jakob_WMDE updated the task description. (Show Details)Oct 14 2019, 4:26 PM
Jakob_WMDE moved this task from Doing to Peer Review on the RL Module Terminators Trailblazing board.
gerritbot added a comment.Oct 14 2019, 4:49 PM

Change 540382 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Remove global access to Wikibase datamodel in js

https://gerrit.wikimedia.org/r/540382

Jakob_WMDE updated the task description. (Show Details)Oct 15 2019, 11:04 AM
gerritbot added a comment.Oct 15 2019, 3:30 PM

Change 542902 merged by jenkins-bot:
[mediawiki/extensions/Citoid@master] Remove global access to Wikibase datamodel in js

https://gerrit.wikimedia.org/r/542902

Jakob_WMDE updated the task description. (Show Details)Oct 15 2019, 3:31 PM
Jakob_WMDE mentioned this in rECEX50771e0d6c54: Remove global access to Wikibase datamodel in js.Oct 15 2019, 3:34 PM
Ladsgroup moved this task from Peer Review to Doing on the RL Module Terminators Trailblazing board.Oct 15 2019, 3:42 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 15 2019, 4:10 PM
gerritbot added a comment.Oct 16 2019, 2:50 PM

Change 543472 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Drop all modules that are parts of datamodel

https://gerrit.wikimedia.org/r/543472

gerritbot added a project: Patch-For-Review.Oct 16 2019, 2:50 PM
Jakob_WMDE mentioned this in rWBDMJS24f10c241e7b: Use CommonJS modules instead of global namespaces.Oct 16 2019, 2:59 PM
Ladsgroup moved this task from Doing to Done on the RL Module Terminators Trailblazing board.Oct 17 2019, 3:31 AM
gerritbot added a comment.Oct 17 2019, 4:04 AM

Change 543472 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Drop all of wikibase.datamodel except the main entry point

https://gerrit.wikimedia.org/r/543472

Maintenance_bot removed a project: Patch-For-Review.Oct 17 2019, 4:10 AM
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.3; 2019-10-22); removed MW-1.35-notes (1.35.0-wmf.2; 2019-10-15).Oct 17 2019, 7:00 AM
Mvolz subscribed.Oct 18 2019, 10:14 AM

I've put in a revert of one of these changes here: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Citoid/+/544167/

We were already not using a global module, i.e. loading it using mw.loading elsewhere in the code, so it should not have affected the tree whatsoever.

However, the way the code is written is that of course when wikibase.datamodel loaded using mw.loading, it is then available from that namespace, which this change did avoid; is that a problem? If so it can be fixed.

Ladsgroup added a comment.EditedOct 18 2019, 10:27 AM
In T233790#5586170, @Mvolz wrote:

We were already not using a global module, i.e. loading it using mw.loading elsewhere in the code, so it should not have affected the tree whatsoever.

I think there's a misunderstanding here, by global, we tend to avoid using wikibase.datamodel.* variables which happens regardless of the way you load the module (as dependency declared or lazy loaded using mw.loader)

Can you explain the problem better to me? We just squeezed all modules to one module called wikibase.datamodel and you load it whatever way you want but use it with require (more info)

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Oct 18 2019, 5:31 PM
Mvolz added a comment.Oct 22 2019, 10:11 AM
In T233790#5586230, @Ladsgroup wrote:
In T233790#5586170, @Mvolz wrote:

We were already not using a global module, i.e. loading it using mw.loading elsewhere in the code, so it should not have affected the tree whatsoever.

I think there's a misunderstanding here, by global, we tend to avoid using wikibase.datamodel.* variables which happens regardless of the way you load the module (as dependency declared or lazy loaded using mw.loader)

Can you explain the problem better to me? We just squeezed all modules to one module called wikibase.datamodel and you load it whatever way you want but use it with require (more info)

Whoops, you're right, sorry about that!

Ladsgroup closed this task as Resolved.Oct 23 2019, 10:57 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL