Add cancel button
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Pablo-WMDE
	Sep 25 2019, 10:16 AM

Description

pimp EventEmittingButton to contain the cancel modification
- add asset (@Charlie_WMDE are we right in assuming this is supposed to be visually identical to the icon in OOUI?) from https://github.com/wikimedia/oojs-ui/ (src/themes/wikimediaui/images/icons/close.svg)
- pick the most reasonable version of delivering that asset - options discussed: background image, embedded SVG (color changeable via CSS)
  - preliminary decision: background image, asset as separate download
- ability to set a title/hidden text
add to storybook

Details

	Subject	Repo	Branch	Lines +/-
	bridge: add cancel button	mediawiki/extensions/Wikibase	master	+205 -29

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Lydia_Pintscher	T231282 cancel modal
		Resolved		• Pablo-WMDE	T233791 Add cancel button

Event Timeline

• Pablo-WMDE created this task.Sep 25 2019, 10:16 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2019, 10:16 AM

• Pablo-WMDE updated the task description. (Show Details)Sep 25 2019, 10:47 AM

• Pablo-WMDE claimed this task.Sep 26 2019, 10:18 AM

• Pablo-WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-6 board.

• Pablo-WMDE mentioned this in T234198: Clean RTL support for assets used in CSS.Sep 30 2019, 10:52 AM

• Pablo-WMDE moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-6 board.Sep 30 2019, 11:01 AM

Change 539526 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: add cancel button

https://gerrit.wikimedia.org/r/539526

gerritbot added a project: Patch-For-Review.Oct 1 2019, 11:53 AM

Change 539526 had a related patch set uploaded (by Matthias Geisler; owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: add cancel button

https://gerrit.wikimedia.org/r/539526

Change 539526 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add cancel button

https://gerrit.wikimedia.org/r/539526

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.1; 2019-10-08).Oct 1 2019, 6:00 PM

Lucas_Werkmeister_WMDE closed this task as Resolved.Oct 2 2019, 10:44 AM

Lucas_Werkmeister_WMDE removed a project: Patch-For-Review.

Lucas_Werkmeister_WMDE moved this task from Peer Review to Verification on the Wikidata-Bridge-Sprint-6 board.

Lucas_Werkmeister_WMDE moved this task from Verification to Done on the Wikidata-Bridge-Sprint-6 board.