Page MenuHomePhabricator

Add cancel button
Closed, ResolvedPublic

Description

  • pimp EventEmittingButton to contain the cancel modification
    • add asset (@Charlie_WMDE are we right in assuming this is supposed to be visually identical to the icon in OOUI?) from https://github.com/wikimedia/oojs-ui/ (src/themes/wikimediaui/images/icons/close.svg)
    • pick the most reasonable version of delivering that asset - options discussed: background image, embedded SVG (color changeable via CSS)
      • preliminary decision: background image, asset as separate download
    • ability to set a title/hidden text
  • add to storybook

Details

Related Gerrit Patches:
mediawiki/extensions/Wikibase : masterbridge: add cancel button

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2019, 10:16 AM
Pablo-WMDE updated the task description. (Show Details)Sep 25 2019, 10:47 AM
Pablo-WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-6 board.

Change 539526 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: add cancel button

https://gerrit.wikimedia.org/r/539526

Change 539526 had a related patch set uploaded (by Matthias Geisler; owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: add cancel button

https://gerrit.wikimedia.org/r/539526

Change 539526 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add cancel button

https://gerrit.wikimedia.org/r/539526