React to escape
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Pablo-WMDE
	Sep 25 2019, 10:27 AM

Description

Initial research showed that just enabling native escape behavior of the OOUI modal does not cut, we need extra steps to ensure that the mark-up is removed.
Do we need to take extra steps to make sure that app is also destroyed, not only "hidden"?

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	bridge: add selenium test for esc event	mediawiki/extensions/Wikibase	master	+41 -0
	bridge: close with esc	mediawiki/extensions/Wikibase	master	+97 -128

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Lydia_Pintscher	T231282 cancel modal
		Resolved		• Matthias_Geisler_WMDE	T233793 React to escape

Event Timeline

• Pablo-WMDE created this task.Sep 25 2019, 10:27 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2019, 10:27 AM

• Pablo-WMDE updated the task description. (Show Details)Sep 25 2019, 10:45 AM

• Matthias_Geisler_WMDE claimed this task.Sep 26 2019, 11:53 AM

• Matthias_Geisler_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-6 board.

Change 539361 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: close with esc

https://gerrit.wikimedia.org/r/539361

gerritbot added a project: Patch-For-Review.Sep 26 2019, 4:22 PM

Change 539370 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: add selenium test for esc event

https://gerrit.wikimedia.org/r/539370

• Matthias_Geisler_WMDE moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-6 board.Sep 26 2019, 4:53 PM

Change 539361 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: close with esc

https://gerrit.wikimedia.org/r/539361

Change 539370 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add selenium test for esc event

https://gerrit.wikimedia.org/r/539370

• Matthias_Geisler_WMDE moved this task from Peer Review to Verification on the Wikidata-Bridge-Sprint-6 board.Oct 1 2019, 4:06 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 1 2019, 4:10 PM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.25; 2019-10-01).Oct 1 2019, 5:00 PM

Lydia_Pintscher closed this task as Resolved.Oct 7 2019, 8:56 AM

Lydia_Pintscher moved this task from Verification to Done on the Wikidata-Bridge-Sprint-6 board.