Page MenuHomePhabricator

React to escape
Closed, ResolvedPublic

Description

Initial research showed that just enabling native escape behavior of the OOUI modal does not cut, we need extra steps to ensure that the mark-up is removed.
Do we need to take extra steps to make sure that app is also destroyed, not only "hidden"?

Details

Related Gerrit Patches:
mediawiki/extensions/Wikibase : masterbridge: add selenium test for esc event
mediawiki/extensions/Wikibase : masterbridge: close with esc

Related Objects

StatusAssignedTask
ResolvedLydia_Pintscher
ResolvedMatthias_Geisler_WMDE

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2019, 10:27 AM
Pablo-WMDE updated the task description. (Show Details)Sep 25 2019, 10:45 AM

Change 539361 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: close with esc

https://gerrit.wikimedia.org/r/539361

Change 539370 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: add selenium test for esc event

https://gerrit.wikimedia.org/r/539370

Change 539361 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: close with esc

https://gerrit.wikimedia.org/r/539361

Change 539370 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add selenium test for esc event

https://gerrit.wikimedia.org/r/539370

Lydia_Pintscher closed this task as Resolved.Oct 7 2019, 8:56 AM
Lydia_Pintscher moved this task from Verification to Done on the Wikidata-Bridge-Sprint-6 board.