Page MenuHomePhabricator

Add cancel button to app and emit close event
Closed, ResolvedPublic

Description

  • use EventEmittingButton in its cancel modification
    • add cancel message ("cancel" from core) to be used in the button's title, ...
  • emit close event on click

Details

Related Gerrit Patches:
mediawiki/extensions/Wikibase : masterbridge: add e2e tests for cancel
mediawiki/extensions/Wikibase : masterbridge: add cancel button to app

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2019, 10:30 AM
Pablo-WMDE updated the task description. (Show Details)Sep 25 2019, 10:50 AM

Change 539897 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: add cancel button to app

https://gerrit.wikimedia.org/r/539897

Change 540111 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: add e2e tests for cancel

https://gerrit.wikimedia.org/r/540111

Change 539897 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add cancel button to app

https://gerrit.wikimedia.org/r/539897

Change 540111 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add e2e tests for cancel

https://gerrit.wikimedia.org/r/540111

Lucas_Werkmeister_WMDE closed this task as Resolved.Oct 2 2019, 10:43 AM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-6 board.