Add cancel button to app and emit close event
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Pablo-WMDE
	Sep 25 2019, 10:30 AM

Description

use EventEmittingButton in its cancel modification
- add cancel message ("cancel" from core) to be used in the button's title, ...
emit close event on click

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/Wikibase	master	+40 -0	bridge: add e2e tests for cancel
	mediawiki/extensions/Wikibase	master	+61 -5	bridge: add cancel button to app

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Lydia_Pintscher	T231282 cancel modal
		Resolved		Lucas_Werkmeister_WMDE	T233795 Add cancel button to app and emit close event

Event Timeline

• Pablo-WMDE created this task.Sep 25 2019, 10:30 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2019, 10:30 AM

• Pablo-WMDE updated the task description. (Show Details)Sep 25 2019, 10:50 AM

Lucas_Werkmeister_WMDE claimed this task.Sep 30 2019, 12:59 PM

Lucas_Werkmeister_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-6 board.

Change 539897 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: add cancel button to app

https://gerrit.wikimedia.org/r/539897

gerritbot added a project: Patch-For-Review.Sep 30 2019, 4:06 PM

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-6 board.Sep 30 2019, 4:06 PM

Change 540111 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: add e2e tests for cancel

https://gerrit.wikimedia.org/r/540111

Change 539897 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add cancel button to app

https://gerrit.wikimedia.org/r/539897

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.1; 2019-10-08).Oct 1 2019, 7:00 PM

Change 540111 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add e2e tests for cancel

https://gerrit.wikimedia.org/r/540111

Lucas_Werkmeister_WMDE closed this task as Resolved.Oct 2 2019, 10:43 AM

Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-6 board.

Maintenance_bot removed a project: Patch-For-Review.Oct 2 2019, 11:10 AM