- use EventEmittingButton in its cancel modification
- add cancel message ("cancel" from core) to be used in the button's title, ...
- emit close event on click
Description
Description
Details
Details
Project | Branch | Lines +/- | Subject | |
---|---|---|---|---|
mediawiki/extensions/Wikibase | master | +40 -0 | bridge: add e2e tests for cancel | |
mediawiki/extensions/Wikibase | master | +61 -5 | bridge: add cancel button to app |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Lydia_Pintscher | T231282 cancel modal | |||
Resolved | Lucas_Werkmeister_WMDE | T233795 Add cancel button to app and emit close event |
Event Timeline
Comment Actions
Change 539897 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: add cancel button to app
Comment Actions
Change 540111 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: add e2e tests for cancel
Comment Actions
Change 539897 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add cancel button to app
Comment Actions
Change 540111 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add e2e tests for cancel