Page MenuHomePhabricator
Create Task
Maniphest T233796

browser test canceling
Closed, ResolvedPublic
Actions

Description

  • via escape
  • via cancel button

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Wikibasemaster+10 -27bridge: reuse duplicate code in can-cancel browser test
mediawiki/extensions/Wikibasemaster+37 -0bridge: add browser test for clicking cancel button
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedLydia_PintscherT231282 cancel modal
 ResolvedMichaelT233796 browser test canceling

Event Timeline

• Pablo-WMDE created this task.Sep 25 2019, 10:50 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2019, 10:50 AM
Lucas_Werkmeister_WMDE moved this task from To do to Peer Review on the Wikidata-Bridge-Sprint-6 board.Sep 27 2019, 10:22 AM
gerritbot added a comment.Sep 27 2019, 10:23 AM

Change 539370 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: add selenium test for esc event

https://gerrit.wikimedia.org/r/539370

gerritbot added a project: Patch-For-Review.Sep 27 2019, 10:23 AM
• Pablo-WMDE added a comment.Sep 27 2019, 11:49 AM

A first browser test, for esc, is already there.

• Pablo-WMDE updated the task description. (Show Details)Sep 27 2019, 11:49 AM
• Matthias_Geisler_WMDE moved this task from Peer Review to To do on the Wikidata-Bridge-Sprint-6 board.Oct 1 2019, 5:12 PM
Michael claimed this task.Oct 2 2019, 9:55 AM
Michael moved this task from To do to Doing on the Wikidata-Bridge-Sprint-6 board.
Restricted Application added a project: User-Michael. · View Herald TranscriptOct 2 2019, 9:55 AM
gerritbot added a comment.Oct 2 2019, 10:38 AM

Change 540372 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] bridge: add browser test for clicking cancel button

https://gerrit.wikimedia.org/r/540372

Michael moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-6 board.Oct 2 2019, 11:13 AM
gerritbot added a comment.Oct 2 2019, 11:59 AM

Change 540388 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: reuse duplicate code in can-cancel browser test

https://gerrit.wikimedia.org/r/540388

gerritbot added a comment.Oct 2 2019, 12:20 PM

Change 540372 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add browser test for clicking cancel button

https://gerrit.wikimedia.org/r/540372

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.1; 2019-10-08).Oct 2 2019, 1:00 PM
gerritbot added a comment.Oct 2 2019, 4:30 PM

Change 540388 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: reuse duplicate code in can-cancel browser test

https://gerrit.wikimedia.org/r/540388

Michael closed this task as Resolved.Oct 7 2019, 9:07 AM
Michael moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-6 board.
Michael removed a project: Patch-For-Review.

All patches got merged. Somehow the Gerrit bot got confused and forgot to report that for the patch that adds the selenium tests for pressing escape.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL