Adding or editing monolingual text fails on beta and test Wikidata
Closed, ResolvedPublic
Actions

Description

Trying at add a new statement with a monolingual string datatype fails with:
jQuery.Deferred exception: LanguageSelector is not a constructor TypeError: LanguageSelector is not a constructor
Trying to edit an existing statement (example) fails with the same error.

I suspect this might be todo with the RL terminators?

Guess if that is the case we might need to revert something soon-ish. As far as I can see it isn't broken on wikidata.org

ping @Jakob_WMDE @Ladsgroup @Rosalie_WMDE

Impact

Monolingual string values cannot be edited (currently on wikidata.beta.wmflabs.org and test.wikidata.org)

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Revert "Merge valueview modules"	mediawiki/extensions/Wikibase	wmf/1.34.0-wmf.24	+87 -37
	Revert "Merge valueview modules"	mediawiki/extensions/Wikibase	master	+87 -37

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	• mmodell	T220749 1.34.0-wmf.24 deployment blockers
		Resolved		Jakob_WMDE	T233800 Adding or editing monolingual text fails on beta and test Wikidata

Event Timeline

Tarrow created this task.Sep 25 2019, 12:18 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2019, 12:18 PM

@Tarrow: Trying to guess a project tag for this task so others can find it. Feel free to correct.

Thanks!

Fails on test.wikidata.org (group0, wmf.24) too.

Lucas_Werkmeister_WMDE added a parent task: T220749: 1.34.0-wmf.24 deployment blockers.Sep 25 2019, 12:22 PM

Lucas_Werkmeister_WMDE added a project: Wikimedia-production-error.

Lucas_Werkmeister_WMDE updated the task description. (Show Details)

Lucas_Werkmeister_WMDE renamed this task from Adding a new monolingual statement fails on beta to Adding or editing monolingual text fails on beta and test Wikidata.Sep 25 2019, 12:28 PM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)

• alaa_wmde subscribed.Sep 25 2019, 12:30 PM

Change 539111 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Revert "Merge valueview modules"

https://gerrit.wikimedia.org/r/539111

gerritbot added a project: Patch-For-Review.Sep 25 2019, 12:32 PM

Marking this as unbreak now to make sure it gets fixed and backported before the issue hits production.

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptSep 25 2019, 1:03 PM

WMDE-leszek subscribed.Sep 25 2019, 1:27 PM

• Agusbou2015 subscribed.Sep 25 2019, 1:32 PM

Change 539111 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Revert "Merge valueview modules"

https://gerrit.wikimedia.org/r/539111

Change 539127 had a related patch set uploaded (by Ladsgroup; owner: Jakob):
[mediawiki/extensions/Wikibase@wmf/1.34.0-wmf.24] Revert "Merge valueview modules"

https://gerrit.wikimedia.org/r/539127

Change 539127 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.34.0-wmf.24] Revert "Merge valueview modules"

https://gerrit.wikimedia.org/r/539127

Seems to work again on beta, so it looks like the fix is working on master.

Mentioned in SAL (#wikimedia-operations) [2019-09-25T14:55:12Z] <ladsgroup@deploy1001> Synchronized php-1.34.0-wmf.24/extensions/Wikibase/view/lib/resources.php: Revert "Merge valueview modules": T233800 (duration: 01m 04s)

And seems to be fixed on Wikidata as well, so lowering priority a bit (but leaving final verification to @Lydia_Pintscher).

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.25; 2019-10-01).Sep 25 2019, 3:00 PM

Confirmed resolved :)

@Tarrow – how did you find this, by the way? Was it caught by any tests? If no, we might want to add some…

Maintenance_bot removed a project: Patch-For-Review.Sep 25 2019, 3:10 PM

Ladsgroup moved this task from Backlog to Done on the RL Module Terminators Trailblazing board.Oct 7 2019, 11:11 AM

Adding or editing monolingual text fails on beta and test WikidataClosed, ResolvedPublicActions