Page MenuHomePhabricator
Create Task
Maniphest T233830

App "isExisting" after close (by save)
Closed, ResolvedPublicBUG REPORT
Actions

Description

https://integration.wikimedia.org/ci/job/wmf-quibble-vendor-mysql-php72-docker/9543/console failed with "App didn't close after clicking save button" but it can not be seen in the screenshot.
Is this a matter of using .isExisting() instead of .isVisible()? Maybe - but we actually want our app to not exist any more (discussed the topic of destroying it today) so this could do with some digging.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
bridge: provide video for failing browser testsmediawiki/extensions/Wikibasemaster+83 -1
bridge: check selenium video in CImediawiki/extensions/Wikibasemaster+1 -0
bridge: prevent flaky browser test when closing appmediawiki/extensions/Wikibasemaster+4 -5
Customize query in gerrit

Event Timeline

• Pablo-WMDE created this task.Sep 25 2019, 5:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2019, 5:27 PM
• Pablo-WMDE updated the task description. (Show Details)Sep 25 2019, 5:29 PM
• Pablo-WMDE updated the task description. (Show Details)Sep 26 2019, 8:37 AM
Michael claimed this task.Sep 26 2019, 9:45 AM
Michael moved this task from To do to Doing on the Wikidata-Bridge-Sprint-6 board.
Restricted Application added a project: User-Michael. · View Herald TranscriptSep 26 2019, 9:45 AM
Michael moved this task from 🗃️ Incoming to ⏳ In progress on the User-Michael board.Sep 26 2019, 9:45 AM
gerritbot added a comment.Sep 26 2019, 11:10 AM

Change 539304 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] bridge: prevent flaky browser test when closing app

https://gerrit.wikimedia.org/r/539304

gerritbot added a project: Patch-For-Review.Sep 26 2019, 11:10 AM
gerritbot added a comment.Sep 26 2019, 2:59 PM

Change 539345 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] bridge: provide video for failing browser tests

https://gerrit.wikimedia.org/r/539345

Michael moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-6 board.Sep 26 2019, 3:29 PM
gerritbot added a comment.Sep 26 2019, 4:27 PM

Change 539304 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: prevent flaky browser test when closing app

https://gerrit.wikimedia.org/r/539304

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.25; 2019-10-01).Sep 26 2019, 5:00 PM
gerritbot added a comment.Sep 27 2019, 10:35 AM

Change 539506 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: check selenium video in CI

https://gerrit.wikimedia.org/r/539506

gerritbot added a comment.Sep 27 2019, 10:59 AM

Change 539506 abandoned by Pablo Grass (WMDE):
bridge: check selenium video in CI

Reason:
Was just to show the effect in CI

https://gerrit.wikimedia.org/r/539506

gerritbot added a comment.Sep 27 2019, 11:40 AM

Change 539345 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: provide video for failing browser tests

https://gerrit.wikimedia.org/r/539345

• Pablo-WMDE closed this task as Resolved.Sep 27 2019, 11:47 AM
• Pablo-WMDE moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-6 board.

Let's keep an eye on this.

Maintenance_bot removed a project: Patch-For-Review.Sep 27 2019, 12:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits