Page MenuHomePhabricator
Create Task
Maniphest T233907

Logic to extract list of statement GUID's and mount the icon to them
Closed, ResolvedPublic
Actions

Description

  • Currently, src/main.ts contains logic which mounts an element statically inserted to the HTML.
  • We want to dynamically insert an element to each reference block and then replace it with the Vue component.
  • The actual displaying/hiding of the icon will be done on the client side.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Wikibasemaster+1 K -86TR: Second statement in devmode and add app element
mediawiki/extensions/Wikibasemaster+10 -7TR: Create element in entry point for showing app
Customize query in gerrit

Event Timeline

noarave created this task.Sep 26 2019, 9:05 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 26 2019, 9:05 AM
noarave updated the task description. (Show Details)Sep 26 2019, 9:06 AM
Tarrow moved this task from To Do to Doing on the Wikidata-Tainted-References-Sprint2 board.Sep 26 2019, 9:24 AM
gerritbot added a comment.Sep 26 2019, 12:10 PM

Change 539320 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] TR: Create element in entry point for showing app

https://gerrit.wikimedia.org/r/539320

gerritbot added a project: Patch-For-Review.Sep 26 2019, 12:10 PM
hoo moved this task from Doing to Peer Review on the Wikidata-Tainted-References-Sprint2 board.Sep 26 2019, 12:14 PM
gerritbot added a comment.Oct 1 2019, 10:10 AM

Change 540091 had a related patch set uploaded (by Tarrow; owner: Noa wmde):
[mediawiki/extensions/Wikibase@master] TR: Second statement in devmode and add app element

https://gerrit.wikimedia.org/r/540091

gerritbot added a comment.Oct 1 2019, 10:20 AM

Change 539320 abandoned by Tarrow:
TR: Create element in entry point for showing app

Reason:
superceeded by I9a244a36fe940a96578ebf997efc885ff3384d30

https://gerrit.wikimedia.org/r/539320

noarave moved this task from Peer Review to Done on the Wikidata-Tainted-References-Sprint2 board.Oct 1 2019, 10:35 AM
gerritbot added a comment.Oct 7 2019, 2:42 PM

Change 540091 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] TR: Second statement in devmode and add app element

https://gerrit.wikimedia.org/r/540091

Maintenance_bot removed a project: Patch-For-Review.Oct 7 2019, 3:10 PM
Lydia_Pintscher closed this task as Resolved.Oct 14 2019, 8:45 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL