Signature syntax ~~~~ is not expanded in the preview
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	thiemowmde
	Sep 26 2019, 1:57 PM

Description

At https://www.mediawiki.org/wiki/Topic:V80l64inuhz2rhyt a user reports the ~~~~ wiki syntax not being expanded in the preview. Luckily this is only a visual inconsistency. After actually importing the file, the syntax is expanded (as expected) on the resulting file description page.

Note this is not only about the ~~~~ syntax, but about all pre-save transforms.

Acceptance criteria:

Pre-save transforms are applied in the preview.
On the resulting file description page, the syntax is expanded as before.

Demo:

Import any file.
Edit the file description.
Add ~~~~.
In the preview, this should be expanded to the current users name.

Details

	Subject	Repo	Branch	Lines +/-
	Apply pre-save transformations (e.g. signature) on preview	mediawiki/extensions/FileImporter	master	+5 -2

Customize query in gerrit

Related Objects

Mentioned In: rEFLI6b5be80f1447: Apply pre-save transformations (e.g. signature) on preview
Mentioned Here: T234253: Signature syntax ~~~~ is not expanded in the conflict resolution UI

Event Timeline

thiemowmde created this task.Sep 26 2019, 1:57 PM

Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptSep 26 2019, 1:57 PM

awight awarded a token.Sep 27 2019, 6:42 AM

awight changed the subtype of this task from "Task" to "Bug Report".

Pikne edited projects, added Two-Column-Edit-Conflict-Merge; removed Move-Files-To-Commons.Sep 27 2019, 4:07 PM

Alsee subscribed.Sep 28 2019, 12:56 PM

@Pikne the task description reads as if this is concerning the FileImporter - so Move-Files-To-Commons should be the correct tag. - Or is something similar happening with the Two-Column-Edit-Conflict-Merge feature? :-)

Uh, I think it was me messing this up. It seems we have the same bug in both extensions. Since I wrote this here with the FileImporter in mind, we should create a separate one for Two-Column-Edit-Conflict-Merge.

Indeed, sorry. I only looked that original report was about edit conflicts and I figured that file imports don't have much to do with signatures. Now I recall that file description pages sometimes do include signatures. :)

No worries, my mistake. :-) Here is the same bug in Two-Column-Edit-Conflict-Merge: T234253: Signature syntax ~~~~ is not expanded in the conflict resolution UI

Change 552772 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Apply pre-save transformations (e.g. signature) on preview

https://gerrit.wikimedia.org/r/552772

gerritbot added a project: Patch-For-Review.Nov 25 2019, 10:02 AM

Change 552772 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Apply pre-save transformations (e.g. signature) on preview

https://gerrit.wikimedia.org/r/552772

thiemowmde mentioned this in rEFLI6b5be80f1447: Apply pre-save transformations (e.g. signature) on preview.Dec 19 2019, 11:10 AM

Maintenance_bot removed a project: Patch-For-Review.Dec 19 2019, 11:10 AM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.14; 2020-01-07).Dec 19 2019, 12:00 PM

Ammarpad closed this task as Resolved.Jan 1 2020, 10:23 AM

Ammarpad assigned this task to thiemowmde.