Page MenuHomePhabricator

Add red outline to inform users on Special:PasswordReset
Closed, DeclinedPublic

Description

As a PRU user, I want to be informed of the enabled preference with red indicator colors on Special:PasswordReset, so that I receive clear visual indicators of the requirement.

Acceptance Criteria:

  • When user inputs data for one field (but PRU is enabled for associated account), the empty input field should display a red outline
  • Once they input information in both fields, the request should be honored

Behavior Example:

  1. User inputs only username (when email address is also required) & submits reset request
  2. The system lets the user know that both are required (via asterisks & red line, theoretically)
  3. Then the user inputs the associated email address -- but they also input a new username, which does not require the email address.
  4. The request should be honored and they should go to the next screen (i.e. no error messaging or red border)

Visual Example:

Event Timeline

ifried created this task.Sep 26 2019, 4:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 26 2019, 4:33 PM
ifried renamed this task from PLACEHOLDER: Add red outline to inform users on Special:PasswordReset [ to Add red outline to inform users on Special:PasswordReset.Sep 26 2019, 5:00 PM
ifried updated the task description. (Show Details)
MaxSem added a subscriber: MaxSem.Oct 1 2019, 7:30 PM

Problem here: currently, there's no API to retrieve another user's preferences, even the ones considered public, e.g. gender. Something like that is needed to implement this functionality.

ifried added a subscriber: Prtksxna.EditedOct 2 2019, 3:30 PM

@Prtksxna We discussed this as a team during Estimation (on Tuesday), and it may not be technically possible. However, it may be possible if the display is not dynamic (but only changes on refresh/new submission of info). Also, there were certain use cases that were brought up, for example:

  1. User inputs only username (when email address is also required) & submits email request
  2. The system lets the user know that both are required (via asterisks & red line, theoretically)
  3. Then the user inputs the associated email address -- but they also input a new username, which does not require the email address.

In this case, is the red border still displayed? Should it go away? My thought was: Both fields have been filled, so user should go to next screen.

ifried updated the task description. (Show Details)Oct 2 2019, 4:13 PM
ifried updated the task description. (Show Details)

However, it may be possible if the display is not dynamic (but only changes on refresh/new submission of info).

I was expecting this to change on refresh so that is correct 👍🏽

  1. User inputs only username (when email address is also required) & submits email request
  2. The system lets the user know that both are required (via asterisks & red line, theoretically)
  3. Then the user inputs the associated email address -- but they also input a new username, which does not require the email address.

Just noting what we discussed in the meeting:
When a user submits this form and either the username, or the email address entered have the setting enabled we'll take them to a success screen that says something along the lines of, "If this email address and username are associated with each other, then a password reset email will be sent."

ifried added a comment.Oct 3 2019, 5:09 PM

@Prtksxna: To point #1, great! I was also imagining this on refresh, but I wanted to double-check/confirm, due to some conversations we had as a team. As for point #2, yes, this part of the requirements can be found in T234454. Thanks!

ifried closed this task as Declined.Dec 10 2019, 9:41 PM

We have decided to take on a new approach for Special:PasswordReset in T238961, which would not inform users of which criteria are required. For this reason, I am marking this ticket as Declined.