Vector tooltip(s).css typo
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	RobinHood70
	Sep 27 2019, 3:18 AM

Description

I'm not familiar enough with skins to know what effect this might have, but there's a filename mismatch in skins/Vector/skin.json. Near the end, under ResourceModuleSkinStyles, it lists skinStyles/jquery.ui/jquery.ui.tooltips.css, but the name of the actual file is jquery.ui.tooltip.css (no s).

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix typo in skin.json ResourceModuleSkinStyles	mediawiki/skins/Vector	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T234092: structure/ResourcesTest should also check conditional skin styles and language scripts

Event Timeline

RobinHood70 created this task.Sep 27 2019, 3:18 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 27 2019, 3:18 AM

Aklapper added a project: good first task.Sep 27 2019, 8:22 AM

Confirmed.

DannyS712 claimed this task.Sep 27 2019, 6:34 PM

Restricted Application added a project: User-DannyS712. · View Herald TranscriptSep 27 2019, 6:34 PM

Change 539600 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/skins/Vector@master] Fix typo in skin.json ResourceModuleSkinStyles

https://gerrit.wikimedia.org/r/539600

gerritbot added a project: Patch-For-Review.Sep 27 2019, 6:34 PM

DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Sep 27 2019, 6:35 PM

DannyS712 mentioned this in T234092: structure/ResourcesTest should also check conditional skin styles and language scripts.

DannyS712 removed projects: Google-Code-in-2019, patch-welcome, good first task.Sep 27 2019, 6:45 PM

Change 539600 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Fix typo in skin.json ResourceModuleSkinStyles

https://gerrit.wikimedia.org/r/539600

DannyS712 closed this task as Resolved.Sep 27 2019, 9:00 PM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.25; 2019-10-01).Sep 27 2019, 9:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 27 2019, 9:10 PM