Page MenuHomePhabricator
Create Task
Maniphest T234022

SiteConfiguration.php - Error "no such wiki" when running runJobs.php
Closed, ResolvedPublic
Actions

Description

Using MediaWiki 1.31.3, PostgreSQL 9.6.15 and PHP 7.3.0 I get the following error when running runJobs.php:

sudo -u www-data php maintenance/runJobs.php

[54b6866197614c7fdd8d6760] [no req] MWException from line 547 of /dev/disk2/mediawiki/mediawiki-1.31.3/includes/SiteConfiguration.php: No such wiki 'wiki-wiki'.
Backtrace:
#0 /dev/disk2/mediawiki/mediawiki-1.31.3/includes/jobqueue/JobQueueGroup.php(453): SiteConfiguration->getConfig(string, array)
#1 /dev/disk2/mediawiki/mediawiki-1.31.3/includes/libs/objectcache/WANObjectCache.php(1243): JobQueueGroup->{closure}(boolean, integer, array, NULL)
#2 /dev/disk2/mediawiki/mediawiki-1.31.3/includes/libs/objectcache/WANObjectCache.php(1117): WANObjectCache->doGetWithSetCallback(string, integer, Closure, array)
#3 /dev/disk2/mediawiki/mediawiki-1.31.3/includes/jobqueue/JobQueueGroup.php(455): WANObjectCache->getWithSetCallback(string, integer, Closure, array)
#4 /dev/disk2/mediawiki/mediawiki-1.31.3/includes/jobqueue/JobQueueGroup.php(324): JobQueueGroup->getCachedConfigVar(string)
#5 /dev/disk2/mediawiki/mediawiki-1.31.3/includes/jobqueue/JobQueueGroup.php(425): JobQueueGroup->getQueueTypes()
#6 /dev/disk2/mediawiki/mediawiki-1.31.3/includes/jobqueue/JobQueueGroup.php(369): JobQueueGroup->getCoalescedQueues()
#7 /dev/disk2/mediawiki/mediawiki-1.31.3/includes/jobqueue/JobQueueGroup.php(254): JobQueueGroup->getQueuesWithJobs()
#8 /dev/disk2/mediawiki/mediawiki-1.31.3/includes/jobqueue/JobRunner.php(165): JobQueueGroup->pop(integer, integer, array)
#9 /dev/disk2/mediawiki/mediawiki-1.31.3/maintenance/runJobs.php(89): JobRunner->run(array)
#10 /dev/disk2/mediawiki/mediawiki-1.31.3/maintenance/doMaintenance.php(94): RunJobs->execute()
#11 /dev/disk2/mediawiki/mediawiki-1.31.3/maintenance/runJobs.php(122): require_once(string)
#12 {main}

Does work when using mySQL.

I'm not sure, but it seems, $wiki is construced using $wgDBname and $wgDBmwschema which results in a wrong wiki-/db-name.

In my case:

$wgDBname = "wiki"
$wgDBmwschema = "wiki"

The database is called wiki, the tables are without a prefix (archive, bot_passwords, etc.)

Details

ProjectBranchLines +/-Subject
mediawiki/coreREL1_31+140 -4rdbms: re-add DB domain sanity checks to LoadBalancer
Customize query in gerrit

Related Objects

Event Timeline

RacingRalf created this task.Sep 27 2019, 9:08 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 27 2019, 9:08 AM
Aklapper added a project: MediaWiki-Maintenance-system.Sep 27 2019, 9:22 AM
RacingRalf added a comment.Sep 27 2019, 9:34 AM

Just installed a new wiki to test my assumption:

$wgDBname = "wikidb"
$wgDBmwschema = "wikischema"

Error:

No such wiki 'wikidb-wikischema'

Wirehead added a subscriber: Wirehead.Oct 6 2019, 3:51 AM

This does not occur if you use the latest 1.33, so it looks like Change ID Ia3c5855b18b98d9fc5bc02fe68358cfa52ccbce1 didn't cherry pick enough...

Hschletz added a subscriber: Hschletz.Jan 28 2020, 12:24 PM

I found the missing change. It's the last one in https://github.com/wikimedia/mediawiki/commit/13eb2c78c42c9fcb73fc3672f700710bafd9a20b?diff=unified#diff-2fc6ae676962d2ca264593770e82c4f6, file includes/libs/rdbms/database/DatabaseDomain.php:

@@ -150,7 +192,12 @@ private function convertToString() {
 		if ( $this->schema !== null ) {
 			$parts[] = $this->schema;
 		}
-		if ( $this->prefix != '' ) {
+		if ( $this->prefix != '' || $this->schema !== null ) {
+			// If there is a schema, then we need the prefix to disambiguate.
+			// For engines like Postgres that use schemas, this awkwardness is hopefully
+			// avoided since it is easy to have one DB per server (to avoid having many users)
+			// and use schema/prefix to have wiki farms. For example, a domain schemes could be
+			// wiki-<project>-<language>, e.g. "wiki-fitness-es"/"wiki-sports-fr"/"wiki-news-en".
 			$parts[] = $this->prefix;
 		}

Successfully tested against MW 1.31.6.

Aklapper added a comment.Feb 7 2020, 5:28 PM

@Hschletz: Thanks for taking a look at the code!

You are very welcome to use developer access to submit the proposed code changes as a Git branch directly into Gerrit which makes it easier to review and provide feedback. If you don't want to set up Git/Gerrit, you can also use the Gerrit Patch Uploader. Thanks again!

saper merged a task: T244678: No such wiki 'pgwiki-mediawiki'. : MWException from line 547 of /usr/local/www/mediawiki/includes/SiteConfiguration.php.Feb 9 2020, 11:28 PM
saper added a subscriber: saper.
saper mentioned this in T193565: Foreign query for metawiki fails with "Table 'centralauth.page' doesn't exist" (DBConnRef mixup?).Feb 9 2020, 11:32 PM
This comment was removed by saper.
gerritbot added a comment.Feb 9 2020, 11:52 PM

Change 571108 had a related patch set uploaded (by saper; owner: Aaron Schulz):
[mediawiki/core@REL1_31] rdbms: re-add DB domain sanity checks to LoadBalancer

https://gerrit.wikimedia.org/r/571108

gerritbot added a project: Patch-For-Review.Feb 9 2020, 11:52 PM
Krinkle added projects: Wikimedia-Rdbms, Platform Engineering.EditedFeb 12 2020, 8:24 PM
Krinkle moved this task from Untriaged to Rdbms library on the Wikimedia-Rdbms board.
Krinkle added a subscriber: Krinkle.

Looks like some sort of backport of custom patch for fixing an rdbms problem on MW 1.31.

saper added a comment.Feb 13 2020, 1:26 PM

Yes, that's what my patch is about.

Krinkle removed a subscriber: Krinkle.Feb 13 2020, 10:30 PM
WDoranWMF added subscribers: thcipriani, WDoranWMF.Feb 19 2020, 8:48 PM

@thcipriani We wanted to check on who decides whether this should be back ported into 1.31, we weren't sure if it was for us to review and merge the change.

thcipriani added a subscriber: CCicalese_WMF.Feb 20 2020, 12:26 AM
In T234022#5898794, @WDoranWMF wrote:

@thcipriani We wanted to check on who decides whether this should be back ported into 1.31, we weren't sure if it was for us to review and merge the change.

I'd defer to @CCicalese_WMF on those questions given all her work on the past few releases.

CCicalese_WMF edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.Feb 20 2020, 4:04 PM

Yes, we should backport this.

CCicalese_WMF triaged this task as Medium priority.Feb 20 2020, 4:04 PM
CCicalese_WMF moved this task from Inbox to External Code Review Needed on the Platform Team Workboards (Clinic Duty Team) board.
Anomie closed this task as Resolved.Mar 11 2020, 4:50 PM
Anomie moved this task from External Code Review Needed to External Code Review Completed on the Platform Team Workboards (Clinic Duty Team) board.
Anomie added a subscriber: Anomie.

The question was more "who is responsible for reviewing and merging backports" than "who decides". But at this point I'm just going to do it to get this done already.

gerritbot added a comment.Mar 11 2020, 4:53 PM

Change 571108 merged by jenkins-bot:
[mediawiki/core@REL1_31] rdbms: re-add DB domain sanity checks to LoadBalancer

https://gerrit.wikimedia.org/r/571108

ReleaseTaggerBot added a project: MW-1.31-release-notes.Mar 11 2020, 5:00 PM
saper added a comment.Mar 11 2020, 11:48 PM

Thank you @Anomie for having this one un-stuck! Much appreciated.

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:41 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 16 2020, 6:38 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL