Add abuse_filter_log.afl_filter_id and afl_global columns
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Daimona
	Sep 27 2019, 3:35 PM

Details

	Subject	Repo	Branch	Lines +/-
	filtered_tables.txt: Add two new columns for abuse_filter_log	operations/puppet	production	+2 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T254646 Reconsidering how we name things
Open	None	T281536 Schema:EditAttemptStep uses non-inclusive language.
Open	None	T279275 Move all the functionality of {Spam,Title}Blacklist extensions into AbuseFilter and retire them
Resolved	None	T290934 Expand the set of bundled extensions and skins in MediaWiki 1.38
Resolved	Daimona	T191740 Bundle AbuseFilter extension with MediaWiki
Resolved	Daimona	T199544 Make AbuseFilter work on PostgreSQL and SQLite (epic)
Resolved	Ladsgroup	T191231 RFC: Abstract schemas and schema changes
Open	None	T259374 Convert extensions to using abstract schema
Resolved	None	T261911 Convert Bundled Extensions to Abstract Schema
Resolved	None	T261912 Convert WMF Deployed Extensions to Abstract Schema
Resolved	Umherirrender	T259377 Migrate AbuseFilter to Abstract Schema
Open	None	T93564 Addition of last hit date to Special:AbuseFilter table
Open	None	T291132 Introduce a value object for the abuse_filter_log table
Resolved	Daimona	T220791 afl_filter should be split in afl_filter_id and afl_global
Resolved	• Marostegui	T234052 Add abuse_filter_log.afl_filter_id and afl_global columns
Resolved	• Bstorm	T234615 Wikireplicas changes for abuse_filter_log including two new columns

Event Timeline

Daimona created this task.Sep 27 2019, 3:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 27 2019, 3:35 PM

Daimona added a parent task: T220791: afl_filter should be split in afl_filter_id and afl_global.Sep 27 2019, 3:42 PM

Stalling until wmf.25 is out: https://tools.wmflabs.org/versions/

Daimona changed the task status from Stalled to Open.Oct 4 2019, 12:31 PM

Change 540855 had a related patch set uploaded (by Marostegui; owner: Marostegui):
[operations/puppet@production] filtered_tables.txt: Add two new columns for abuse_filter_log

https://gerrit.wikimedia.org/r/540855

gerritbot added a project: Patch-For-Review.Oct 4 2019, 12:37 PM

• Marostegui mentioned this in T234615: Wikireplicas changes for abuse_filter_log including two new columns.Oct 4 2019, 12:41 PM

• Marostegui changed the status of subtask T234615: Wikireplicas changes for abuse_filter_log including two new columns from Open to Stalled.

Change 540855 merged by Marostegui:
[operations/puppet@production] filtered_tables.txt: Add two new columns for abuse_filter_log

https://gerrit.wikimedia.org/r/540855

• Marostegui updated the task description. (Show Details)Oct 4 2019, 12:45 PM

• Marostegui moved this task from Backlog to Pending comment on the DBA board.

Maintenance_bot removed a project: Patch-For-Review.Oct 4 2019, 1:10 PM

Daimona mentioned this in T54201: API should always return the filter id as a number.Nov 26 2019, 1:56 PM

• Marostegui claimed this task.Jan 2 2020, 1:17 PM

• Marostegui moved this task from Backlog to In progress on the Schema-change-in-production board.

• Marostegui moved this task from Pending comment to In progress on the DBA board.

Mentioned in SAL (#wikimedia-operations) [2020-01-02T13:23:44Z] <marostegui> Deploy schema change on s5 codfw master (db2123) with replication - T234052

I have altered s5 codfw wikis and this is how the table looks like now:

mysql.py -hdb2123 dewiki -e "show create table abuse_filter_log\G"
*************************** 1. row ***************************
       Table: abuse_filter_log
Create Table: CREATE TABLE `abuse_filter_log` (
  `afl_id` bigint(20) unsigned NOT NULL AUTO_INCREMENT,
  `afl_filter` varbinary(64) NOT NULL DEFAULT '',
  `afl_global` tinyint(1) NOT NULL DEFAULT '0',
  `afl_filter_id` bigint(20) unsigned NOT NULL DEFAULT '0',
  `afl_user` bigint(20) unsigned NOT NULL DEFAULT '0',
  `afl_user_text` varbinary(255) NOT NULL DEFAULT '',
  `afl_ip` varbinary(255) NOT NULL DEFAULT '',
  `afl_action` varbinary(255) NOT NULL DEFAULT '',
  `afl_actions` varbinary(255) NOT NULL DEFAULT '',
  `afl_var_dump` blob NOT NULL,
  `afl_timestamp` varbinary(14) NOT NULL DEFAULT '',
  `afl_namespace` int(11) NOT NULL,
  `afl_title` varbinary(255) NOT NULL DEFAULT '',
  `afl_wiki` varbinary(64) DEFAULT NULL,
  `afl_deleted` tinyint(1) NOT NULL DEFAULT '0',
  `afl_patrolled_by` int(10) unsigned NOT NULL DEFAULT '0',
  `afl_rev_id` int(10) unsigned DEFAULT NULL,
  PRIMARY KEY (`afl_id`),
  KEY `afl_timestamp` (`afl_timestamp`),
  KEY `afl_rev_id` (`afl_rev_id`),
  KEY `filter_timestamp` (`afl_filter`,`afl_timestamp`),
  KEY `user_timestamp` (`afl_user`,`afl_user_text`,`afl_timestamp`),
  KEY `page_timestamp` (`afl_namespace`,`afl_title`,`afl_timestamp`),
  KEY `ip_timestamp` (`afl_ip`,`afl_timestamp`),
  KEY `wiki_timestamp` (`afl_wiki`,`afl_timestamp`),
  KEY `filter_timestamp_full` (`afl_global`,`afl_filter_id`,`afl_timestamp`)
) ENGINE=InnoDB AUTO_INCREMENT=651043 DEFAULT CHARSET=binary

@Daimona ^ looks good to you?

• Marostegui updated the task description. (Show Details)Jan 2 2020, 1:27 PM

In T234052#5770727, @Marostegui wrote:

@Daimona ^ looks good to you?

Yes, thanks!

In T234052#5770727, @Marostegui wrote:

@Daimona ^ looks good to you?

Thanks for confirming!

Mentioned in SAL (#wikimedia-operations) [2020-01-02T14:22:11Z] <marostegui> Deploy schema change on s5 eqiad hosts - T234052

• Marostegui updated the task description. (Show Details)Jan 2 2020, 2:23 PM

Mentioned in SAL (#wikimedia-operations) [2020-01-02T14:27:34Z] <marostegui> Deploy schema change on s6 codfw master (db2129) with replication - T234052

• Marostegui updated the task description. (Show Details)Jan 2 2020, 2:34 PM

• Marostegui updated the task description. (Show Details)Jan 2 2020, 2:59 PM

Mentioned in SAL (#wikimedia-operations) [2020-01-03T06:57:21Z] <marostegui> Deploy schema change on s6 eqiad hosts - T234052

• Marostegui updated the task description. (Show Details)Jan 3 2020, 7:08 AM

Mentioned in SAL (#wikimedia-operations) [2020-01-03T07:09:59Z] <marostegui> Deploy schema change on s2 codfw master, lag will appear on codfw - T234052

• Marostegui updated the task description. (Show Details)Jan 3 2020, 7:33 AM

Mentioned in SAL (#wikimedia-operations) [2020-01-03T08:17:21Z] <marostegui> Deploy schema change on labswiki (wikitech) T234052

@Andrew can you check if this schema change applies also to labtestwiki and if so, run it?
Thanks!

• Marostegui updated the task description. (Show Details)Jan 3 2020, 8:26 AM

• Marostegui updated the task description. (Show Details)Jan 3 2020, 1:49 PM

Mentioned in SAL (#wikimedia-operations) [2020-01-03T13:50:48Z] <marostegui> Deploy schema change on s4 codfw (lag will appear on codfw s4) - T234052

• Marostegui updated the task description. (Show Details)Jan 3 2020, 2:01 PM

Mentioned in SAL (#wikimedia-operations) [2020-01-03T14:58:08Z] <marostegui> Deploy schema changes on s2 and s4 eqiad hosts T234052

• Marostegui updated the task description. (Show Details)Jan 3 2020, 3:02 PM

Mentioned in SAL (#wikimedia-operations) [2020-01-07T07:03:03Z] <marostegui> Deploy schema change on s8 codfw (this will generate lag on s8 codfw) - T234052

• Marostegui updated the task description. (Show Details)Jan 7 2020, 7:24 AM

• Marostegui updated the task description. (Show Details)Jan 7 2020, 2:21 PM

Mentioned in SAL (#wikimedia-operations) [2020-01-07T14:21:29Z] <marostegui> Deploy schema change on s2 codfw master, this will generate lag on s2 codfw - T234052

Mentioned in SAL (#wikimedia-operations) [2020-01-07T14:22:16Z] <marostegui> Deploy schema change on s7 codfw master, this will generate lag on s7 codfw - T234052

• Marostegui updated the task description. (Show Details)Jan 7 2020, 2:44 PM

@Andrew I have executed this alter on labtestwiki on clouddb2001-dev

Mentioned in SAL (#wikimedia-operations) [2020-01-08T07:57:59Z] <marostegui> Deploy schema change on clouddb2001-dev.labtestwiki - T234052

• Marostegui updated the task description. (Show Details)Jan 8 2020, 7:58 AM

• Marostegui updated the task description. (Show Details)Jan 8 2020, 8:05 AM

Mentioned in SAL (#wikimedia-operations) [2020-01-08T08:07:11Z] <marostegui> Deploy schema change on s1 codfw, there will be lag on s1 codfw - T234052

• Marostegui updated the task description. (Show Details)Jan 8 2020, 8:18 AM

• Marostegui updated the task description. (Show Details)Jan 9 2020, 8:19 AM

Mentioned in SAL (#wikimedia-operations) [2020-01-09T12:41:43Z] <marostegui> Deploy schema change on s3 codfw, lag will appear on s3 codfw - T234052

• Marostegui updated the task description. (Show Details)Jan 9 2020, 12:56 PM

• Marostegui updated the task description. (Show Details)Jan 9 2020, 1:54 PM

In T234052#5785015, @Marostegui wrote:

@Andrew I have executed this alter on labtestwiki on clouddb2001-dev

Thank you! I was on vacation :)

Mentioned in SAL (#wikimedia-operations) [2020-01-13T06:00:13Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depool db1075 T234052', diff saved to https://phabricator.wikimedia.org/P10123 and previous config saved to /var/cache/conftool/dbconfig/20200113-060012-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2020-01-13T06:10:26Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repool db1075 T234052', diff saved to https://phabricator.wikimedia.org/P10126 and previous config saved to /var/cache/conftool/dbconfig/20200113-061025-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2020-01-13T06:11:39Z] <marostegui> Deploy schema change on s1 master (db1083) - T234052

• Marostegui updated the task description. (Show Details)Jan 13 2020, 6:33 AM

Mentioned in SAL (#wikimedia-operations) [2020-01-13T06:36:03Z] <marostegui> Deploy schema change on db1112 with replication (lag will appear on s3 on labs) - T234052

All done

Daimona awarded a token.Jan 13 2020, 10:37 AM

Daimona changed the status of subtask T234615: Wikireplicas changes for abuse_filter_log including two new columns from Stalled to Open.

• Bstorm closed subtask T234615: Wikireplicas changes for abuse_filter_log including two new columns as Resolved.Mar 15 2021, 6:53 PM

Add abuse_filter_log.afl_filter_id and afl_global columnsClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Add abuse_filter_log.afl_filter_id and afl_global columns
Closed, ResolvedPublic
Actions

Related Objects
Search...