Page MenuHomePhabricator

Don't allow requeueing main page
Closed, ResolvedPublic

Description

Following up from enwiki discussion at https://en.wikipedia.org/w/index.php?title=Wikipedia:Interface_administrators%27_noticeboard&oldid=918230402
The #p-pagetriage-enqueue list item really isn't useful on {{MediaWiki:Mainpage}} - do we need to hack this off project side or can it be fixed centrally?

Can be fixed centrally; the main page doesn't need to be patrolled or requeued. Thus, the option shouldn't be shown. It also shouldn't be allowed via the API.

  • Remove display of element on main page
  • Don't allow requeueing via API

Details

Related Gerrit Patches:
mediawiki/extensions/PageTriage : masterDon't allow enqueueing main page via API
mediawiki/extensions/PageTriage : masterDon't show option to enqueue main page

Event Timeline

Restricted Application added a project: User-DannyS712. · View Herald TranscriptSep 27 2019, 5:22 PM

Change 539584 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PageTriage@master] Don't show option to enqueue main page

https://gerrit.wikimedia.org/r/539584

Change 539606 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PageTriage@master] Don't allow enqueueing main page via API

https://gerrit.wikimedia.org/r/539606

@MusikAnimal can you take a look at the second patch I submitted? The API shouldn't allow it either

Change 539584 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Don't show option to enqueue main page

https://gerrit.wikimedia.org/r/539584

DannyS712 renamed this task from Don't show option to requeue main page to Don't allow requeueing main page.Sep 27 2019, 9:09 PM
DannyS712 updated the task description. (Show Details)

Why would a New Page Reviewer want to relist the main page?
As far as I understand, relisting is confined to users of the NPR right, is that not so?

Why would a New Page Reviewer want to relist the main page?
As far as I understand, relisting is confined to users of the NPR right, is that not so?

I don't think one would (at least not in good faith), but if anyone did, it would *probably* result in the toolbar being shown to admins & patrollers for a full month; better safe than sorry

OK, I'll buy that.

Change 539606 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Don't allow enqueueing main page via API

https://gerrit.wikimedia.org/r/539606

MusikAnimal updated the task description. (Show Details)Oct 2 2019, 7:47 PM

Thanks DannyS712! Everything looks good in my testing but we'll put this through QA just in case.

With my Admin user ("Dom walden") on both https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page and https://test.wikipedia.org/wiki/Main_Page I cannot see the "Add to the New Pages Feed" link.

Attempting to enqueue the main page via the API I see the error: The main page cannot be added to the pagetriage queue.

There is a possibility that if the main page is a redirect to another page (such as it is on dewiki), the page that it is redirected to might show the "Add to the New Pages Feed" link. However, PageTriage is only on enwiki so would only be a problem if enwiki decide to make their main page into a redirect.

This change should now be on production.

These changes should now be live. It would be great if a New Page Reviewer can confirm that it is working as expected, so tagging @Barkeep49 and @Insertcleverphrasehere. Thanks!

Api error
{
    "error": {
        "code": "bad-pagetriage-enqueue-mainpage",
        "info": "The main page cannot be added to the pagetriage queue",
        "*": "See https://en.wikipedia.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at <https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce> for notice of API deprecations and breaking changes."
    },
    "servedby": "mw1344"
}

confirmed to be working

ifried closed this task as Resolved.Thu, Oct 31, 10:13 PM
ifried moved this task from Product sign-off to Done on the Community-Tech (Kanban-Q2-2019-20) board.

Thanks, @DannyS712. I'll mark this work as Done.