Highlight individual statements when selecting them in the URL
Closed, ResolvedPublic
Actions

Description

T178745: Highlight statement(s) when using "#P" in URL highlights the whole statement group when its property ID is selected in the URL hash, but you can also target individual statements this way, and it would be nice to highlight them, too.

Details

	Subject	Repo	Branch	Lines +/-
	Highlight individual :target statements	mediawiki/extensions/Wikibase	master	+7 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T218402 Make statement groups clickable and append property IDs to the URLs
Resolved	abian	T178745 Highlight statement(s) when using "#P" in URL
Resolved	abian	T234079 Highlight individual statements when selecting them in the URL

Event Timeline

Lucas_Werkmeister_WMDE created this task.Sep 27 2019, 5:54 PM

Restricted Application added a project: Design. · View Herald TranscriptSep 27 2019, 5:54 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 533917 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Abián):
[mediawiki/extensions/Wikibase@master] Highlight individual :target statements

https://gerrit.wikimedia.org/r/533917

gerritbot added a project: Patch-For-Review.Sep 27 2019, 5:56 PM

The change linked above implements this; here’s what it looks like if the statement is not the first in the list:

Screenshot_2019-09-27 Douglas Adams.png (432×933 px, 21 KB)

@Hanna_Petruschat_WMDE does this look okay to you?

Lucas_Werkmeister_WMDE mentioned this in T178745: Highlight statement(s) when using "#P" in URL.Sep 27 2019, 5:59 PM

Thanks for the task, @Lucas_Werkmeister_WMDE!

Note that, when you load the page with the hash, you'll have the property name inside the box anyway, since the property name follows you when you scroll down.

👍

Lydia_Pintscher edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.Oct 10 2019, 12:56 PM

Lydia_Pintscher moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Oct 18 2019, 5:30 PM

Change 533917 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Highlight individual :target statements

https://gerrit.wikimedia.org/r/533917

Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Oct 23 2019, 11:23 AM

@Lydia_Pintscher @Hanna_Petruschat_WMDE this can be tested on beta now
e.g. https://wikidata.beta.wmflabs.org/wiki/Q112#Q112$d41ca394-46ec-aa3b-f442-748873dbbbfe

Maintenance_bot removed a project: Patch-For-Review.Oct 23 2019, 12:10 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.4; 2019-10-29).Oct 23 2019, 5:00 PM