Page MenuHomePhabricator
Create Task
Maniphest T234223

Single row view in Logstash hidden by Phatality
Closed, ResolvedPublic
Actions

Assigned To
• mmodell
Authored By
Krinkle
Sep 30 2019, 2:39 PM
Tags
Referenced Files
F30510216: Screenshot 2019-09-30 at 17.53.12.png
Sep 30 2019, 4:53 PM
F30510217: Screenshot 2019-09-30 at 17.53.16.png
Sep 30 2019, 4:53 PM
F30509998: Screenshot 2019-09-30 at 15.38.01.png
Sep 30 2019, 2:39 PM
F30509996: Screenshot 2019-09-30 at 15.37.48.png
Sep 30 2019, 2:39 PM
Subscribers
Aklapper
fgiunchedi
Krinkle
• mmodell

Description

When viewing rows in Logstash that are not directly coming from MediaWiki (e.g. logs from other services, or e.g. the raw php-fpm logs).

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-syslog-2019.09.30/syslog?id=AW2CerSYsRi4qkyR8hWc

Actual

Screenshot 2019-09-30 at 15.37.48.png (1×2 px, 175 KB)

Expected

Screenshot 2019-09-30 at 15.38.01.png (1×2 px, 512 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Move phatality'a tab to the end in the list of doc view tabs.releng/phatalitymaster+1 -1
Customize query in gerrit

Event Timeline

Krinkle created this task.Sep 30 2019, 2:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 30 2019, 2:39 PM
fgiunchedi added subscribers: • mmodell, fgiunchedi.Sep 30 2019, 3:50 PM

cc @mmodell

• mmodell claimed this task.Sep 30 2019, 3:52 PM

Hopefully this is an easy fix.

gerritbot added a comment.Sep 30 2019, 4:10 PM

Change 539898 had a related patch set uploaded (by 20after4; owner: 20after4):
[releng/phatality@master] Move phatality'a tab to the end in the list of doc view tabs.

https://gerrit.wikimedia.org/r/539898

gerritbot added a project: Patch-For-Review.Sep 30 2019, 4:10 PM
• mmodell triaged this task as High priority.Sep 30 2019, 4:13 PM
Krinkle removed a subscriber: 20after4.Sep 30 2019, 4:52 PM

(sorry, pinged wrong account)

This seems to affect the main view as well. There, things are not hidden, but it causes the (+) plus and (-) minus icons to be missing.

Screenshot 2019-09-30 at 17.53.12.png (1×1 px, 217 KB)

Screenshot 2019-09-30 at 17.53.16.png (1×1 px, 263 KB)

Probably the same issue, but reporting just in case.

• mmodell added a comment.Sep 30 2019, 4:55 PM

@Krinkle: The phatality view doesn't include the details, you have to click to the table view to see the + / - buttons. But my patch (above) fixes both issues by making table view the default tab and you'll have to click the phatality tab to get to the phatality functionality.

gerritbot added a comment.Sep 30 2019, 4:55 PM

Change 539898 merged by 20after4:
[releng/phatality@master] Move phatality'a tab to the end in the list of doc view tabs.

https://gerrit.wikimedia.org/r/539898

• mmodell added a comment.Sep 30 2019, 4:57 PM

Ok not I just need to deploy it.

Stashbot added a comment.Sep 30 2019, 5:08 PM

Mentioned in SAL (#wikimedia-operations) [2019-09-30T17:08:36Z] <twentyafterfour> deploying minor update to phatality to fix T234223

Stashbot added a comment.Sep 30 2019, 5:09 PM

Mentioned in SAL (#wikimedia-operations) [2019-09-30T17:09:18Z] <twentyafterfour@deploy1001> Started deploy [releng/phatality@62e2870]: fix T234223

Maintenance_bot removed a project: Patch-For-Review.Sep 30 2019, 5:10 PM
Stashbot added a comment.Sep 30 2019, 5:15 PM

Mentioned in SAL (#wikimedia-operations) [2019-09-30T17:15:43Z] <twentyafterfour@deploy1001> deploy aborted: fix T234223 (duration: 06m 24s)

Stashbot added a comment.Sep 30 2019, 5:18 PM

Mentioned in SAL (#wikimedia-operations) [2019-09-30T17:18:36Z] <twentyafterfour@deploy1001> Started deploy [releng/phatality@62e2870]: fix T234223

Stashbot added a comment.Sep 30 2019, 5:18 PM

Mentioned in SAL (#wikimedia-operations) [2019-09-30T17:18:44Z] <twentyafterfour@deploy1001> Finished deploy [releng/phatality@62e2870]: fix T234223 (duration: 00m 05s)

Stashbot added a comment.Sep 30 2019, 5:24 PM

Mentioned in SAL (#wikimedia-operations) [2019-09-30T17:22:26Z] <twentyafterfour@deploy1001> Started deploy [releng/phatality@62e2870]: fix T234223

Stashbot added a comment.Sep 30 2019, 5:33 PM

Mentioned in SAL (#wikimedia-operations) [2019-09-30T17:33:27Z] <twentyafterfour@deploy1001> Started deploy [releng/phatality@62e2870]: fix T234223

Stashbot added a comment.Sep 30 2019, 5:36 PM

Mentioned in SAL (#wikimedia-operations) [2019-09-30T17:36:31Z] <twentyafterfour@deploy1001> Finished deploy [releng/phatality@62e2870]: fix T234223 (duration: 03m 03s)

• mmodell closed this task as Resolved.Sep 30 2019, 5:37 PM

fixed.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits