Page MenuHomePhabricator

Single row view in Logstash hidden by Phatality
Closed, ResolvedPublic

Description

When viewing rows in Logstash that are not directly coming from MediaWiki (e.g. logs from other services, or e.g. the raw php-fpm logs).

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-syslog-2019.09.30/syslog?id=AW2CerSYsRi4qkyR8hWc

Actual

Expected

Event Timeline

Krinkle created this task.Mon, Sep 30, 2:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMon, Sep 30, 2:39 PM
mmodell claimed this task.Mon, Sep 30, 3:52 PM

Hopefully this is an easy fix.

Change 539898 had a related patch set uploaded (by 20after4; owner: 20after4):
[releng/phatality@master] Move phatality'a tab to the end in the list of doc view tabs.

https://gerrit.wikimedia.org/r/539898

mmodell triaged this task as High priority.Mon, Sep 30, 4:13 PM
Krinkle removed a subscriber: 20after4.Mon, Sep 30, 4:52 PM

(sorry, pinged wrong account)

This seems to affect the main view as well. There, things are not hidden, but it causes the (+) plus and (-) minus icons to be missing.

Probably the same issue, but reporting just in case.

@Krinkle: The phatality view doesn't include the details, you have to click to the table view to see the + / - buttons. But my patch (above) fixes both issues by making table view the default tab and you'll have to click the phatality tab to get to the phatality functionality.

Change 539898 merged by 20after4:
[releng/phatality@master] Move phatality'a tab to the end in the list of doc view tabs.

https://gerrit.wikimedia.org/r/539898

Ok not I just need to deploy it.

Mentioned in SAL (#wikimedia-operations) [2019-09-30T17:08:36Z] <twentyafterfour> deploying minor update to phatality to fix T234223

Mentioned in SAL (#wikimedia-operations) [2019-09-30T17:09:18Z] <twentyafterfour@deploy1001> Started deploy [releng/phatality@62e2870]: fix T234223

Mentioned in SAL (#wikimedia-operations) [2019-09-30T17:15:43Z] <twentyafterfour@deploy1001> deploy aborted: fix T234223 (duration: 06m 24s)

Mentioned in SAL (#wikimedia-operations) [2019-09-30T17:18:36Z] <twentyafterfour@deploy1001> Started deploy [releng/phatality@62e2870]: fix T234223

Mentioned in SAL (#wikimedia-operations) [2019-09-30T17:18:44Z] <twentyafterfour@deploy1001> Finished deploy [releng/phatality@62e2870]: fix T234223 (duration: 00m 05s)

Mentioned in SAL (#wikimedia-operations) [2019-09-30T17:22:26Z] <twentyafterfour@deploy1001> Started deploy [releng/phatality@62e2870]: fix T234223

Mentioned in SAL (#wikimedia-operations) [2019-09-30T17:33:27Z] <twentyafterfour@deploy1001> Started deploy [releng/phatality@62e2870]: fix T234223

Mentioned in SAL (#wikimedia-operations) [2019-09-30T17:36:31Z] <twentyafterfour@deploy1001> Finished deploy [releng/phatality@62e2870]: fix T234223 (duration: 03m 03s)

mmodell closed this task as Resolved.Mon, Sep 30, 5:37 PM

fixed.