I've tried to deliver some messages using MassMessage today. I first make some test messages to check if MassMessage was still working.
We are really dependent on this tool, and not having it reliably delivering messages is really impacting Community-Relations work.
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| mediawiki/services/change-propagation | master | +4 -3 | Take job domain into account when deduplicating. |
Just to contextualise – among other things, this means that the weekly technical newsletter on which we rely to inform the communities about upcoming problems, changes, new features, feedback we need to get on tools being developed and so on can't be delivered. Basically, we're very limited in our ability to talk to the communities.
Ok. I know what's happening, I'm sorry about that. This is a regression of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MassMessage/+/538742
The deduplication info provided by the default Job duplicate handler doesn't take the job domain into account, thus it deduplicates jobs with the same parameters across wikis.
Change 539899 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/services/change-propagation@master] Take job domain into account when deduplicating.
Change 539899 abandoned by Ppchelko:
Take job domain into account when deduplicating.
Reason:
muscle memory
Mentioned in SAL (#wikimedia-operations) [2019-09-30T16:32:40Z] <ppchelko@deploy1001> Started deploy [cpjobqueue/deploy@79db711]: Take job domain into account for deduplication T234226
Mentioned in SAL (#wikimedia-operations) [2019-09-30T16:34:00Z] <ppchelko@deploy1001> Finished deploy [cpjobqueue/deploy@79db711]: Take job domain into account for deduplication T234226 (duration: 01m 17s)